Re: [PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-05-04 Thread Mike Rapoport
Tony Lindgren wrote: * Mike Rapoport mike.rapop...@gmail.com [100503 13:28]: So it comes down to what provides better tolerance, the explicit NAND timings in nanosecs or (rounded) timings in ticks derived from bootloader settings... My experience is that you can get the nanosec timings from

Re: [PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-05-04 Thread Tony Lindgren
* Mike Rapoport m...@compulab.co.il [100504 06:19]: Tony Lindgren wrote: * Mike Rapoport mike.rapop...@gmail.com [100503 13:28]: So it comes down to what provides better tolerance, the explicit NAND timings in nanosecs or (rounded) timings in ticks derived from bootloader settings... My

Re: [PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-05-03 Thread Tony Lindgren
* Mike Rapoport m...@compulab.co.il [100429 01:44]: Signed-off-by: Mike Rapoport m...@compulab.co.il Please add a proper description to all the patches. --- a/arch/arm/mach-omap2/gpmc-nand.c +++ b/arch/arm/mach-omap2/gpmc-nand.c @@ -116,6 +124,11 @@ int __init gpmc_nand_init(struct

Re: [PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-05-03 Thread Mike Rapoport
On Mon, May 3, 2010 at 9:24 PM, Tony Lindgren t...@atomide.com wrote: * Mike Rapoport m...@compulab.co.il [100429 01:44]: Signed-off-by: Mike Rapoport m...@compulab.co.il Please add a proper description to all the patches. --- a/arch/arm/mach-omap2/gpmc-nand.c +++

Re: [PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-05-03 Thread Tony Lindgren
* Mike Rapoport mike.rapop...@gmail.com [100503 13:28]: On Mon, May 3, 2010 at 9:24 PM, Tony Lindgren t...@atomide.com wrote: * Mike Rapoport m...@compulab.co.il [100429 01:44]: Signed-off-by: Mike Rapoport m...@compulab.co.il Please add a proper description to all the patches. ---

[PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

2010-04-30 Thread Mike Rapoport
Signed-off-by: Mike Rapoport m...@compulab.co.il --- arch/arm/mach-omap2/gpmc-nand.c| 21 + arch/arm/plat-omap/include/plat/nand.h |1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c