Re: [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-08 Thread Archit Taneja
On Tuesday 08 May 2012 02:22 PM, Tomi Valkeinen wrote: On Tue, 2012-05-08 at 13:08 +0530, Archit Taneja wrote: On Tuesday 08 May 2012 12:46 PM, Tomi Valkeinen wrote: I'm not sure if it applies here, but as a general strategy, I suggest doing things in apply.c that require data from apply.c's

Re: [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-08 Thread Tomi Valkeinen
On Tue, 2012-05-08 at 13:08 +0530, Archit Taneja wrote: > On Tuesday 08 May 2012 12:46 PM, Tomi Valkeinen wrote: > > I'm not sure if it applies here, but as a general strategy, I suggest > > doing things in apply.c that require data from apply.c's internal data. > > When that's not possible, apply

Re: [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-08 Thread Archit Taneja
On Tuesday 08 May 2012 12:46 PM, Tomi Valkeinen wrote: On Tue, 2012-05-08 at 10:33 +0530, Archit Taneja wrote: On Monday 07 May 2012 08:33 PM, Tomi Valkeinen wrote: On Thu, 2012-05-03 at 12:37 +0530, Archit Taneja wrote: In order to check the validity of overlay and manager info, there was a n

Re: [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-08 Thread Tomi Valkeinen
On Tue, 2012-05-08 at 10:33 +0530, Archit Taneja wrote: > On Monday 07 May 2012 08:33 PM, Tomi Valkeinen wrote: > > On Thu, 2012-05-03 at 12:37 +0530, Archit Taneja wrote: > >> In order to check the validity of overlay and manager info, there was a > >> need to > >> use the omap_dss_device struct

Re: [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-07 Thread Archit Taneja
On Monday 07 May 2012 08:33 PM, Tomi Valkeinen wrote: On Thu, 2012-05-03 at 12:37 +0530, Archit Taneja wrote: In order to check the validity of overlay and manager info, there was a need to use the omap_dss_device struct to get the panel resolution. The manager's private data in APPLY now contai

Re: [PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-07 Thread Tomi Valkeinen
On Thu, 2012-05-03 at 12:37 +0530, Archit Taneja wrote: > In order to check the validity of overlay and manager info, there was a need > to > use the omap_dss_device struct to get the panel resolution. The manager's > private data in APPLY now contains the manager timings. Hence, we don't need >

[PATCH v2 4/4] OMAPDSS: APPLY: Remove display dependency from overlay and manager checks

2012-05-03 Thread Archit Taneja
In order to check the validity of overlay and manager info, there was a need to use the omap_dss_device struct to get the panel resolution. The manager's private data in APPLY now contains the manager timings. Hence, we don't need to rely on the display resolution any more. Create a function dss_m