Re: [PATCH v2 5/8] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-04-19 Thread Paul Walmsley
Hi On Mon, 27 Feb 2012, Paul Walmsley wrote: Move the code that reprograms the OCP_SYSCONFIG bits into the _reset() function to ensure that it is called after every reset. The code was previously in the _setup() function. So, before this patch, if _reset() was called from another function,

Re: [PATCH v2 5/8] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-04-11 Thread Paul Walmsley
On Thu, 15 Mar 2012, Ramirez Luna, Omar wrote: On Thu, Mar 15, 2012 at 1:25 AM, Paul Walmsley p...@pwsan.com wrote: On Wed, 14 Mar 2012, Ramirez Luna, Omar wrote: If we reached here the reset lines will be asserted, and then the code below touches sysc registers on a module under reset.

Re: [PATCH v2 5/8] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-03-15 Thread Paul Walmsley
Hola Omar, On Wed, 14 Mar 2012, Ramirez Luna, Omar wrote: If we reached here the reset lines will be asserted, and then the code below touches sysc registers on a module under reset. Do you know of any case where this would be a problem? Seems like it would only affect IP blocks that have

Re: [PATCH v2 5/8] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-03-15 Thread Ramirez Luna, Omar
On Thu, Mar 15, 2012 at 1:25 AM, Paul Walmsley p...@pwsan.com wrote: Hola Omar, Hola :) On Wed, 14 Mar 2012, Ramirez Luna, Omar wrote: If we reached here the reset lines will be asserted, and then the code below touches sysc registers on a module under reset. Do you know of any case where

Re: [PATCH v2 5/8] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-03-14 Thread Ramirez Luna, Omar
Hi Paul, 2012/2/27 Paul Walmsley p...@pwsan.com: diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index db4ad41..aeb6f4c 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c @@ -1490,13 +1490,22 @@ static int _reset(struct

[PATCH v2 5/8] ARM: OMAP2+: hwmod: ensure that SYSCONFIG bits are reprogrammed after a reset

2012-02-27 Thread Paul Walmsley
Move the code that reprograms the OCP_SYSCONFIG bits into the _reset() function to ensure that it is called after every reset. The code was previously in the _setup() function. So, before this patch, if _reset() was called from another function, the SYSCONFIG register won't be reprogrammed.