Convert a printk(KERN_ERR) message in the driver to pr_err().
v2:
* Replaced dump_stack() with WARN()
v3:
* Rebased against omap/master
Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
arch/arm/plat-omap/dmtimer.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
On Fri, Oct 07, 2011 at 10:50:16AM +0200, Víctor Manuel Jáquez Leal wrote:
Convert a printk(KERN_ERR) message in the driver to pr_err().
...
@@ -111,7 +111,7 @@ static void omap_dm_timer_wait_for_reset(struct
omap_dm_timer *timer)
while (!(__raw_readl(timer-sys_stat) 1)) {
On Fri, Oct 07, 2011 at 10:22:43AM +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 10:50:16AM +0200, Víctor Manuel Jáquez Leal wrote:
Convert a printk(KERN_ERR) message in the driver to pr_err().
...
@@ -111,7 +111,7 @@ static void omap_dm_timer_wait_for_reset(struct
On Fri, 2011-10-07 at 10:22 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 10:50:16AM +0200, Víctor Manuel Jáquez Leal wrote:
Convert a printk(KERN_ERR) message in the driver to pr_err().
...
@@ -111,7 +111,7 @@ static void omap_dm_timer_wait_for_reset(struct
omap_dm_timer
On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote:
At some point in the next couple of years, I want
to convert all of, or as many as possible of, the
remaining printk uses to pr_level.
If the idea is also to get rid of printk() too (which IMHO would be a
good thing as it kills off
On Fri, 2011-10-07 at 20:18 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote:
At some point in the next couple of years, I want
to convert all of, or as many as possible of, the
remaining printk uses to pr_level.
If the idea is also to get
On Fri, Oct 07, 2011 at 12:48:21PM -0700, Joe Perches wrote:
On Fri, 2011-10-07 at 20:18 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 10:40:39AM -0700, Joe Perches wrote:
At some point in the next couple of years, I want
to convert all of, or as many as possible of, the
On Fri, 2011-10-07 at 20:57 +0100, Russell King - ARM Linux wrote:
On Fri, Oct 07, 2011 at 12:48:21PM -0700, Joe Perches wrote:
I think it needs to be done subsystem by subsystem,
arch by arch, as maintainers accept.
Agreed - but doing one instance here, maybe another instance somewhere