Re: [PATCH v3 05/13] gpio/omap: get rid of retrigger variable in gpio_irq_handler

2012-03-12 Thread Kevin Hilman
Tarun Kanti DebBarma tarun.ka...@ti.com writes: This local variable is just assigned zero and then OR'ed with isr. It does not appear to serve any purpose and so removing it. Still missing the changelog changes I requested in v1. Kevin Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com

Re: [PATCH v3 05/13] gpio/omap: get rid of retrigger variable in gpio_irq_handler

2012-03-12 Thread Kevin Hilman
DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Wed, Mar 7, 2012 at 4:45 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This local variable is just assigned zero and then OR'ed with isr. It does not appear to serve any purpose and so removing it. Missed following comments from

Re: [PATCH v3 05/13] gpio/omap: get rid of retrigger variable in gpio_irq_handler

2012-03-09 Thread DebBarma, Tarun Kanti
On Wed, Mar 7, 2012 at 4:45 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: This local variable is just assigned zero and then OR'ed with isr. It does not appear to serve any purpose and so removing it. Missed following comments from Kevin given in v2. Sorry about that. I have updated the

[PATCH v3 05/13] gpio/omap: get rid of retrigger variable in gpio_irq_handler

2012-03-07 Thread Tarun Kanti DebBarma
This local variable is just assigned zero and then OR'ed with isr. It does not appear to serve any purpose and so removing it. Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Felipe Balbi ba...@ti.com ---