Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Mark A. Greer
On Fri, Nov 09, 2012 at 10:00:31AM -0800, Tony Lindgren wrote: > * Paul Walmsley [121109 09:13]: > > On Fri, 9 Nov 2012, Mark A. Greer wrote: > > > > > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > > > > > Why not using macros as it was before? > > > > > > > > OMAP24XX_

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Tony Lindgren
* Paul Walmsley [121109 09:13]: > On Fri, 9 Nov 2012, Mark A. Greer wrote: > > > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > > > Why not using macros as it was before? > > > > > > OMAP24XX_SEC_SHA1MD5_BASE > > > > I am following the precedent set in the existing code

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Paul Walmsley
On Fri, 9 Nov 2012, Mark A. Greer wrote: > On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > > > Why not using macros as it was before? > > > > OMAP24XX_SEC_SHA1MD5_BASE > > I am following the precedent set in the existing code of that file > which uses the actual address inste

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Mark A. Greer
On Fri, Nov 09, 2012 at 06:10:20PM +0200, Kasatkin, Dmitry wrote: > Hello, Thanks for your comments, Dmitry. > On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > > From: "Mark A. Greer" > > > > Convert the device data for the OMAP2 SHAM crypto IP from > > explicit platform_data to hwmod. >

Re: [PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-09 Thread Kasatkin, Dmitry
Hello, On Wed, Nov 7, 2012 at 4:57 AM, Mark A. Greer wrote: > From: "Mark A. Greer" > > Convert the device data for the OMAP2 SHAM crypto IP from > explicit platform_data to hwmod. > > CC: Paul Walmsley > Signed-off-by: Mark A. Greer > --- > arch/arm/mach-omap2/clock2430_data.c

[PATCH v3 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod

2012-11-06 Thread Mark A. Greer
From: "Mark A. Greer" Convert the device data for the OMAP2 SHAM crypto IP from explicit platform_data to hwmod. CC: Paul Walmsley Signed-off-by: Mark A. Greer --- arch/arm/mach-omap2/clock2430_data.c | 1 + arch/arm/mach-omap2/devices.c | 34 --