On Mon, Jul 15, 2013 at 01:33:53PM +0200, Lars-Peter Clausen wrote:
On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote:
[...]
+ ret = devm_request_threaded_irq(dev, irq, NULL,
+ twl6030_gpadc_irq_handler,
+ IRQF_ONESHOT, twl6030_gpadc, gpadc);
You access memory in the interrupt
On 07/17/2013 03:45 PM, Oleksandr Kozaruk wrote:
On Mon, Jul 15, 2013 at 01:33:53PM +0200, Lars-Peter Clausen wrote:
On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote:
[...]
+ ret = devm_request_threaded_irq(dev, irq, NULL,
+ twl6030_gpadc_irq_handler,
+ IRQF_ONESHOT, twl6030_gpadc,
Hello Lars-Peter,
Thank you for the review.
diff --git a/drivers/iio/adc/twl6030-gpadc.c
b/drivers/iio/adc/twl6030-gpadc.c
new file mode 100644
index 000..6ceb789
--- /dev/null
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -0,0 +1,1019 @@
[...]
+static u8 twl6032_channel_to_reg(int
On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote:
[...]
+ ret = devm_request_threaded_irq(dev, irq, NULL,
+ twl6030_gpadc_irq_handler,
+ IRQF_ONESHOT, twl6030_gpadc, gpadc);
You access memory in the interrupt
Hi All,
I have a question regarding this patch and IIO in general
- Does IIO provide sync mechanism with system wide suspend/resume or
this should be handled by each driver itself?
What if during system suspend iio_read_channel_raw() (or any other
consumer API) will be called after gpadc
On 07/15/2013 01:56 PM, Grygorii Strashko wrote:
Hi All,
I have a question regarding this patch and IIO in general
- Does IIO provide sync mechanism with system wide suspend/resume or this
should be handled by each driver itself?
What if during system suspend iio_read_channel_raw() (or
Hello Jonathan,
Thanks for the review.
Couple of things:
1) It looks from the driver that a lot of the channels are not measuring
voltages but rather temperature or currents etc. If so then their
types in the channel mask should be appropriately set. Also if some
of the channels are entirely
On 15/07/13 14:30, Kozaruk, Oleksandr wrote:
Hello Jonathan,
Thanks for the review.
Couple of things:
1) It looks from the driver that a lot of the channels are not measuring
voltages but rather temperature or currents etc. If so then their
types in the channel mask should be
The GPADC is general purpose ADC found on TWL6030,
and TWL6032 PMIC, known also as Phoenix and PhoenixLite.
The TWL6030 and TWL6032 have GPADC with 17 and 19
channels respectively. Some channels have current
source and are used for measuring voltage drop
on resistive load for detecting battery ID
On 07/12/2013 08:18 AM, Oleksandr Kozaruk wrote:
The GPADC is general purpose ADC found on TWL6030,
and TWL6032 PMIC, known also as Phoenix and PhoenixLite.
The TWL6030 and TWL6032 have GPADC with 17 and 19
channels respectively. Some channels have current
source and are used for measuring
A couple of comments inline.
On 07/12/2013 09:18 AM, Oleksandr Kozaruk wrote:
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index ab0767e6..87d699e 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -157,4 +157,12 @@ config VIPERBOARD_ADC
Say yes
11 matches
Mail list logo
