Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-06 Thread Ivan Djelic
On Wed, Dec 05, 2012 at 05:15:52AM +, Philip, Avinash wrote: (...) First a short reminder of pros and cons of the constant polynomial addition (let's just call it CPA) feature: pros: - it elegantly solves all problems related to reading an erased page (no clumsy hack needed)

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-06 Thread Philip, Avinash
On Thu, Dec 06, 2012 at 15:45:41, Ivan Djelic wrote: On Wed, Dec 05, 2012 at 05:15:52AM +, Philip, Avinash wrote: (...) First a short reminder of pros and cons of the constant polynomial addition (let's just call it CPA) feature: pros: - it elegantly solves all problems

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-04 Thread Philip, Avinash
On Sun, Dec 02, 2012 at 03:20:14, Ivan Djelic wrote: On Wed, Nov 28, 2012 at 05:01:30AM +, Philip, Avinash wrote: (...) Daniel, So can you start supporting bch8-am335xrbl-compatible and remove usage of is_elm_used in dt. This should come in ecc_opt field. In omap2 NAND

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-12-01 Thread Ivan Djelic
On Wed, Nov 28, 2012 at 05:01:30AM +, Philip, Avinash wrote: (...) Daniel, So can you start supporting bch8-am335xrbl-compatible and remove usage of is_elm_used in dt. This should come in ecc_opt field. In omap2 NAND driver, AM335x RBL compatibility is achieved depending on

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-27 Thread Philip, Avinash
On Tue, Nov 27, 2012 at 19:30:54, Daniel Mack wrote: Hi Avinash, Hi Peter, On 23.11.2012 11:43, Philip, Avinash wrote: On Wed, Nov 21, 2012 at 15:45:23, Daniel Mack wrote: On 20.11.2012 16:59, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Peter, In patch

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-23 Thread Philip, Avinash
On Wed, Nov 21, 2012 at 15:45:23, Daniel Mack wrote: On 20.11.2012 16:59, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Hi, In omap2 driver NAND_ECC_HW ecc mode supports 3 ecc layout OMAP_ECC_HAMMING_CODE_HW_ROMCODE OMAP_ECC_BCH4_CODE_HW

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-21 Thread Daniel Mack
On 20.11.2012 16:59, Peter Korsgaard wrote: Daniel == Daniel Mack zon...@gmail.com writes: Hi, In omap2 driver NAND_ECC_HW ecc mode supports 3 ecc layout OMAP_ECC_HAMMING_CODE_HW_ROMCODE OMAP_ECC_BCH4_CODE_HW OMAP_ECC_BCH8_CODE_HW So selection of ecc layout data should

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-20 Thread Peter Korsgaard
Daniel == Daniel Mack zon...@gmail.com writes: Hi, In omap2 driver NAND_ECC_HW ecc mode supports 3 ecc layout OMAP_ECC_HAMMING_CODE_HW_ROMCODE OMAP_ECC_BCH4_CODE_HW OMAP_ECC_BCH8_CODE_HW So selection of ecc layout data should come from DT not ecc mode. Ok, I see. I would still

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-18 Thread Philip, Avinash
On Sun, Nov 11, 2012 at 00:26:32, Daniel Mack wrote: On 07.11.2012 16:37, Philip, Avinash wrote: On Wed, Nov 07, 2012 at 15:18:37, Daniel Mack wrote: On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-14 Thread Daniel Mack
On 11.11.2012 02:56, Daniel Mack wrote: On 07.11.2012 16:37, Philip, Avinash wrote: On Wed, Nov 07, 2012 at 15:18:37, Daniel Mack wrote: On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-10 Thread Daniel Mack
On 07.11.2012 16:37, Philip, Avinash wrote: On Wed, Nov 07, 2012 at 15:18:37, Daniel Mack wrote: On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote:

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-07 Thread Daniel Mack
On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-07 Thread Philip, Avinash
On Wed, Nov 07, 2012 at 15:18:37, Daniel Mack wrote: On 05.11.2012 14:29, Philip, Avinash wrote: On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-05 Thread Philip, Avinash
On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND. Code was added to parse the generic GPMC

Re: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-05 Thread Daniel Mack
On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND.

RE: [PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-05 Thread Philip, Avinash
On Mon, Nov 05, 2012 at 18:28:22, Daniel Mack wrote: On 05.11.2012 12:03, Philip, Avinash wrote: On Fri, Nov 02, 2012 at 20:55:56, Daniel Mack wrote: This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from child nodes within the GPMC node, and the

[PATCH v3 4/4] ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND

2012-11-02 Thread Daniel Mack
This patch adds basic DT bindings for OMAP GPMC. The actual peripherals are instanciated from child nodes within the GPMC node, and the only type of device that is currently supported is NAND. Code was added to parse the generic GPMC timing parameters and some documentation with examples on how