Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Cousson, Benoit
On 2/23/2011 6:47 PM, Kadiyala, Kishore wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of by hwmod framework. 2) Removing all base address macro defines except keeping one for OMAP2420. 3) Using omap-device layer to register device and utilizing data

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Kadiyala, Kishore
On Thu, Feb 24, 2011 at 5:19 PM, Cousson, Benoit b-cous...@ti.com wrote: On 2/23/2011 6:47 PM, Kadiyala, Kishore wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of    by hwmod framework. 2) Removing all base address macro defines except keeping one for

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Kadiyala, Kishore
On Thu, Feb 24, 2011 at 11:58 AM, Varadarajan, Charulatha ch...@ti.com wrote: Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of   by hwmod framework. 2) Removing all base

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Cousson, Benoit
On 2/24/2011 2:55 PM, Kadiyala, Kishore wrote: On Thu, Feb 24, 2011 at 5:19 PM, Cousson, Benoitb-cous...@ti.com wrote: On 2/23/2011 6:47 PM, Kadiyala, Kishore wrote: [...] static struct hsmmc_controller { charname[HSMMC_NAME_LEN + 1]; -}

[PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-23 Thread Kishore Kadiyala
Changes involves: 1) Remove controller reset in devices.c which is taken care of by hwmod framework. 2) Removing all base address macro defines except keeping one for OMAP2420. 3) Using omap-device layer to register device and utilizing data from hwmod data file for base address, dma channel

Re: [PATCH v3 5/5] OMAP: adapt hsmmc to hwmod framework

2011-02-23 Thread Varadarajan, Charulatha
Kishore, On Wed, Feb 23, 2011 at 23:17, Kishore Kadiyala kishore.kadiy...@ti.com wrote: Changes involves: 1) Remove controller reset in devices.c which is taken care of   by hwmod framework. 2) Removing all base address macro defines except keeping one for OMAP2420. why? 3) Using