RE: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-09 Thread Mohammed, Afzal
Hi Jon, On Tue, May 08, 2012 at 20:43:19, Hunter, Jon wrote: > >> In fact if you migrate to runtime pm then we should not have the clk_get > >> in the gpmc_init any more. > > > > Even if converted to RPM, to get clk rate, clk_get has to be done > > somewhere, right ? > > Yes exactly. However, y

Re: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-08 Thread Jon Hunter
Hi Afzal, On 05/08/2012 01:24 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Mon, May 07, 2012 at 21:42:35, Hunter, Jon wrote: > >>> Clk_prd is a platform data passed to the driver, so platform code >>> updates it, where else can it be done ? >> >> The point is that you can pass what ever you like.

RE: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-07 Thread Mohammed, Afzal
Hi Jon, On Mon, May 07, 2012 at 21:42:35, Hunter, Jon wrote: > > Clk_prd is a platform data passed to the driver, so platform code > > updates it, where else can it be done ? > > The point is that you can pass what ever you like. You do not need to > pass the frequency you can pass the clock han

Re: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-07 Thread Jon Hunter
Hi Afzal, On 05/07/2012 06:02 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Fri, May 04, 2012 at 22:00:21, Hunter, Jon wrote: > + > + pdata->clk_prd = gpmc_get_fclk_period(); Does this need to be done here? May be this should be done in the probe function. You could store the

RE: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-07 Thread Mohammed, Afzal
Hi Jon, On Fri, May 04, 2012 at 22:00:21, Hunter, Jon wrote: > >>> + > >>> + pdata->clk_prd = gpmc_get_fclk_period(); > >> > >> Does this need to be done here? May be this should be done in the probe > >> function. You could store the handle to the main clk in the pdata. > > > > This is done so t

Re: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-04 Thread Jon Hunter
Hi Afzal, On 05/03/2012 03:37 AM, Mohammed, Afzal wrote: > Hi Jon, > > On Wed, May 02, 2012 at 02:11:48, Hunter, Jon wrote: >>> + >>> + pdata->clk_prd = gpmc_get_fclk_period(); >> >> Does this need to be done here? May be this should be done in the probe >> function. You could store the handle

RE: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-03 Thread Mohammed, Afzal
Hi Jon, On Wed, May 02, 2012 at 02:11:48, Hunter, Jon wrote: > > + > > + pdata->clk_prd = gpmc_get_fclk_period(); > > Does this need to be done here? May be this should be done in the probe > function. You could store the handle to the main clk in the pdata. This is done so that migration of g

Re: [PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-01 Thread Jon Hunter
Hi Afzal, On 05/01/2012 07:19 AM, Afzal Mohammed wrote: > Create API for platforms to adapt gpmc to HWMOD > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 52 > +++- > arch/arm/plat-omap/include/plat/gpmc.h |1 + > 2 files cha

[PATCH v4 02/39] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-05-01 Thread Afzal Mohammed
Create API for platforms to adapt gpmc to HWMOD Signed-off-by: Afzal Mohammed --- arch/arm/mach-omap2/gpmc.c | 52 +++- arch/arm/plat-omap/include/plat/gpmc.h |1 + 2 files changed, 38 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-omap2/