Re: [PATCH v4 2/4] OMAP4: Keyboard device registration

2010-06-22 Thread Abraham Arce
Charu, Kevin, On Thu, Jun 17, 2010 at 4:08 PM, Kevin Hilman wrote: > "Varadarajan, Charulatha" writes: [...] >>> + >>> +    oh = omap_hwmod_lookup(oh_name); >> >> Use omap_hwmod_for_each_by_class() instead of lookup by name. > > Yes. how about handling all keypad data in devices.c and add oma

Re: [PATCH v4 2/4] OMAP4: Keyboard device registration

2010-06-17 Thread Kevin Hilman
"Varadarajan, Charulatha" writes: [...] >> + >> +int omap4_init_kp(struct omap4_keypad_platform_data *kp) >> +{ >> +struct omap_hwmod *oh; >> +struct omap_device *od; >> +struct omap4_keypad_platform_data *pdata; >> + >> +unsigned int id = 0; >> +char *name = "omap4-keypad";

RE: [PATCH v4 2/4] OMAP4: Keyboard device registration

2010-06-16 Thread Varadarajan, Charulatha
> -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] > On Behalf Of Abraham Arce > Sent: Wednesday, June 16, 2010 9:39 PM > To: linux-in...@vger.kernel.org; linux-omap@vger.kernel.org > Cc: Arce, Abraham >

[PATCH v4 2/4] OMAP4: Keyboard device registration

2010-06-16 Thread Abraham Arce
Register keyboard device with hwmod framework Signed-off-by: Abraham Arce --- arch/arm/mach-omap2/devices.c | 50 + 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 03e6c9