Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-24 Thread Felipe Balbi
On Wed, Nov 24, 2010 at 10:46:04AM +0530, Varadarajan, Charulatha wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 48e161c..a1c6bd9 100644 --- a/arch/arm/plat-omap/mailbox.c +++ b/arch/arm/plat-omap/mailbox.c @@ -358,6 +358,10 @@ int omap_mbox_register(struct

Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-24 Thread Varadarajan, Charulatha
On Wed, Nov 24, 2010 at 13:52, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 24, 2010 at 10:46:04AM +0530, Varadarajan, Charulatha wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 48e161c..a1c6bd9 100644 --- a/arch/arm/plat-omap/mailbox.c +++

Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-24 Thread Felipe Balbi
On Wed, Nov 24, 2010 at 02:20:40PM +0530, Varadarajan, Charulatha wrote: On Wed, Nov 24, 2010 at 13:52, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 24, 2010 at 10:46:04AM +0530, Varadarajan, Charulatha wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index

Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-24 Thread Kanigeri, Hari
On Wed, Nov 24, 2010 at 2:50 AM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 13:52, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 24, 2010 at 10:46:04AM +0530, Varadarajan, Charulatha wrote: diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index

Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-24 Thread Varadarajan, Charulatha
Hari, On Wed, Nov 24, 2010 at 18:31, Kanigeri, Hari h-kanige...@ti.com wrote: On Wed, Nov 24, 2010 at 2:50 AM, Varadarajan, Charulatha ch...@ti.com wrote: On Wed, Nov 24, 2010 at 13:52, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 24, 2010 at 10:46:04AM +0530, Varadarajan, Charulatha wrote:

[PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-23 Thread Hari Kanigeri
disablign rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Defined rev field in mailbox structure to differentiate the mailbox versions. Signed-off-by: Hari Kanigeri

Re: [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-23 Thread Varadarajan, Charulatha
On Wed, Nov 24, 2010 at 02:56, Hari Kanigeri h-kanige...@ti.com wrote: Should the subject be like this? OMAP4: mailbox: fix rx interrupt disable disablign rx interrupt on omap4 is different than its pre-decessors. Typo -disablign The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to