Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-12 Thread Arnd Bergmann
On Wednesday 11 March 2015 11:05:47 Javier Martinez Canillas wrote: On Wed, Mar 11, 2015 at 10:51 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 01:34:19 Javier Martinez Canillas wrote: + +static struct wl12xx_platform_data * +wlcore_get_platform_data(struct device

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-12 Thread Javier Martinez Canillas
Hello Arnd, On Wed, Mar 11, 2015 at 10:51 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 01:34:19 Javier Martinez Canillas wrote: + +static struct wl12xx_platform_data * +wlcore_get_platform_data(struct device *dev) +{ + struct wl12xx_platform_data *pdata; +

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-11 Thread Arnd Bergmann
On Wednesday 11 March 2015 01:34:19 Javier Martinez Canillas wrote: + +static struct wl12xx_platform_data * +wlcore_get_platform_data(struct device *dev) +{ + struct wl12xx_platform_data *pdata; + + /* first, look for DT data */ I thought it was the opposite, that

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-11 Thread Eliad Peller
On Wed, Mar 11, 2015 at 11:51 AM, Arnd Bergmann a...@arndb.de wrote: +static void wlcore_del_platform_data(struct wl12xx_platform_data *pdata) +{ + kfree(pdata); +} + This function seems to be an unnecessary, why not just call kfree() directly? Or better, maybe the

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-10 Thread Javier Martinez Canillas
Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties

[PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-09 Thread Eliad Peller
When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-09 Thread Arnd Bergmann
On Monday 09 March 2015 17:36:41 Eliad Peller wrote: @@ -323,11 +388,14 @@ out: static void wl1271_remove(struct sdio_func *func) { struct wl12xx_sdio_glue *glue = sdio_get_drvdata(func); + struct wlcore_platdev_data *pdev_data = glue-core-dev.platform_data; + struct