[...]
+static const struct dev_pm_ops gpio_pm_ops = {
+ .suspend = omap_gpio_suspend,
+ .resume = omap_gpio_resume,
+};
Please use SET_SYSTEM_SLEEP_PM_OPS(). See linux/pm.h
We can use following macro to initialize .suspend and .resume callbacks.
But
On Fri, Sep 9, 2011 at 6:02 PM, DebBarma, Tarun Kanti
tarun.ka...@ti.com wrote:
[...]
+static const struct dev_pm_ops gpio_pm_ops = {
+ .suspend = omap_gpio_suspend,
+ .resume = omap_gpio_resume,
+};
Please use SET_SYSTEM_SLEEP_PM_OPS(). See
DebBarma, Tarun Kanti tarun.ka...@ti.com writes:
[...]
+static const struct dev_pm_ops gpio_pm_ops = {
+ .suspend = omap_gpio_suspend,
+ .resume = omap_gpio_resume,
+};
Please use SET_SYSTEM_SLEEP_PM_OPS(). See linux/pm.h
We can use following macro
On Fri, Sep 9, 2011 at 11:34 PM, Kevin Hilman khil...@ti.com wrote:
DebBarma, Tarun Kanti tarun.ka...@ti.com writes:
[...]
+static const struct dev_pm_ops gpio_pm_ops = {
+ .suspend = omap_gpio_suspend,
+ .resume = omap_gpio_resume,
+};
Please use
DebBarma, Tarun Kanti tarun.ka...@ti.com writes:
On Fri, Sep 9, 2011 at 11:34 PM, Kevin Hilman khil...@ti.com wrote:
DebBarma, Tarun Kanti tarun.ka...@ti.com writes:
[...]
+static const struct dev_pm_ops gpio_pm_ops = {
+ .suspend = omap_gpio_suspend,
+ .resume
Tarun Kanti DebBarma tarun.ka...@ti.com writes:
Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
for enabling/disabling clocks appropriately. Remove syscore_ops and
instead use dev_pm_ops now.
Signed-off-by: Charulatha V ch...@ti.com
Signed-off-by: Tarun Kanti DebBarma
[...]
+ /*
+ * If this is the first gpio_request for the bank,
+ * enable the bank module.
+ */
+ if (!bank-mod_usage)
+ if (IS_ERR_VALUE(pm_runtime_get_sync(bank-dev) 0)) {
All of the IS_ERR_VALUE() usage is wrong here. You're checking if the
result
Call runtime pm APIs pm_runtime_get_sync() and pm_runtime_put_sync()
for enabling/disabling clocks appropriately. Remove syscore_ops and
instead use dev_pm_ops now.
Signed-off-by: Charulatha V ch...@ti.com
Signed-off-by: Tarun Kanti DebBarma tarun.ka...@ti.com
Reviewed-by: Santosh Shilimkar
