Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-12-02 Thread Jyri Sarha
On 12/01/2014 09:31 PM, Mark Brown wrote: On Mon, Dec 01, 2014 at 11:07:06AM +0200, Tomi Valkeinen wrote: On 29/11/14 13:59, Mark Brown wrote: Reviewed-by: Mark Brown broo...@kernel.org Thanks. And just to be sure, that's ok, we can merge these in the next merge window? Yes. but like

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-12-01 Thread Tomi Valkeinen
On 29/11/14 13:59, Mark Brown wrote: On Wed, Nov 12, 2014 at 04:40:51PM +0200, Jyri Sarha wrote: The patches are based on: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git for-next The base, the patches, and couple of additional not-to-be-merged omap2plus_defconfig patches can

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-12-01 Thread Mark Brown
On Mon, Dec 01, 2014 at 11:07:06AM +0200, Tomi Valkeinen wrote: On 29/11/14 13:59, Mark Brown wrote: Reviewed-by: Mark Brown broo...@kernel.org Thanks. And just to be sure, that's ok, we can merge these in the next merge window? Yes. but like I said in reply to the patch adding the new

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-29 Thread Mark Brown
On Wed, Nov 12, 2014 at 04:40:51PM +0200, Jyri Sarha wrote: The patches are based on: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git for-next The base, the patches, and couple of additional not-to-be-merged omap2plus_defconfig patches can be found here:

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-26 Thread Tomi Valkeinen
On 25/11/14 20:10, Mark Brown wrote: On Tue, Nov 25, 2014 at 11:26:36AM +0200, Tomi Valkeinen wrote: On 24/11/14 19:39, Mark Brown wrote: The whole series is about HDMI audio, not video. You know exactly what I mean - the early patches are in drivers/video, don't touch anything outside of

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-25 Thread Tomi Valkeinen
On 24/11/14 19:39, Mark Brown wrote: OK... this is all telling me that I *really* need to scrub this in detail. It's all sounding very vague, it's an area which seems to cause lots of problems and I don't want to be sitting here next time around trying to figure out if another rewrite makes

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-25 Thread Mark Brown
On Tue, Nov 25, 2014 at 11:26:36AM +0200, Tomi Valkeinen wrote: On 24/11/14 19:39, Mark Brown wrote: The whole series is about HDMI audio, not video. You know exactly what I mean - the early patches are in drivers/video, don't touch anything outside of that and have no obvious

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-24 Thread Tomi Valkeinen
On 21/11/14 18:14, Mark Brown wrote: On Fri, Nov 21, 2014 at 02:35:07PM +0200, Jyri Sarha wrote: On 11/21/2014 01:23 PM, Mark Brown wrote: With this specific series I also need to figure out what all the video side is about (like I said earlier a lot of the patches look like they're

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-24 Thread Tomi Valkeinen
On 21/11/14 18:38, Mark Brown wrote: On Fri, Nov 21, 2014 at 02:10:11PM +0200, Jyri Sarha wrote: OMAP HDMI audio is fundamentally different to the case on Armada or on BBB. In omap the whole HDMI IP is integrated to the SoC and there really is no codec in the ASoC sense. The the cpu-dai

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-24 Thread Jyri Sarha
On 11/21/2014 06:38 PM, Mark Brown wrote: On Fri, Nov 21, 2014 at 02:10:11PM +0200, Jyri Sarha wrote: OMAP HDMI audio is fundamentally different to the case on Armada or on BBB. In omap the whole HDMI IP is integrated to the SoC and there really is no codec in the ASoC sense. The the cpu-dai

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-24 Thread Mark Brown
On Mon, Nov 24, 2014 at 10:18:31AM +0200, Tomi Valkeinen wrote: On 21/11/14 18:14, Mark Brown wrote: But in what way is it broken and how did this happen? Why are none of I don't have a clear answer, but it probably involves lack of use, and buggy and hard to use implementation. Things

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-21 Thread Mark Brown
On Thu, Nov 20, 2014 at 12:59:44PM +0200, Tomi Valkeinen wrote: The series looks good to me, and works for me. Do you have any comments for the sound/ parts? If not, I can merge this series via fbdev tree, and for that I'd like your ack on the sound/ patches. I've not reviewed it yet and I'm

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-21 Thread Jyri Sarha
On 11/21/2014 01:23 PM, Mark Brown wrote: On Thu, Nov 20, 2014 at 12:59:44PM +0200, Tomi Valkeinen wrote: The series looks good to me, and works for me. Do you have any comments for the sound/ parts? If not, I can merge this series via fbdev tree, and for that I'd like your ack on the

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-21 Thread Jyri Sarha
On 11/21/2014 01:23 PM, Mark Brown wrote: With this specific series I also need to figure out what all the video side is about (like I said earlier a lot of the patches look like they're supposed to be simple fixes for the video code not terribly closely tied to the rest of the series but none

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-21 Thread Mark Brown
On Fri, Nov 21, 2014 at 02:35:07PM +0200, Jyri Sarha wrote: On 11/21/2014 01:23 PM, Mark Brown wrote: With this specific series I also need to figure out what all the video side is about (like I said earlier a lot of the patches look like they're supposed to be simple fixes for the video code

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-21 Thread Mark Brown
On Fri, Nov 21, 2014 at 02:10:11PM +0200, Jyri Sarha wrote: OMAP HDMI audio is fundamentally different to the case on Armada or on BBB. In omap the whole HDMI IP is integrated to the SoC and there really is no codec in the ASoC sense. The the cpu-dai transmits the audio directly to hdmi wire

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-20 Thread Tomi Valkeinen
Hi Mark, On 13/11/14 10:05, Tomi Valkeinen wrote: Hi Mark, On 13/11/14 00:23, Mark Brown wrote: On Wed, Nov 12, 2014 at 04:40:51PM +0200, Jyri Sarha wrote: It would make the most sense to get these in trough fbdev tree. So it would be nice to get acked-bys (if the patches are Ok) for ASoC

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-14 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 17:44:38 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] a) Always keep the audio device operational, no matter what is the status of the video side. How should this work if the HDMI videomode or the HDMI monitor does not support audio? Is it desirable

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Tomi Valkeinen
Hi Mark, On 13/11/14 00:23, Mark Brown wrote: On Wed, Nov 12, 2014 at 04:40:51PM +0200, Jyri Sarha wrote: It would make the most sense to get these in trough fbdev tree. So it would be nice to get acked-bys (if the patches are Ok) for ASoC side changes from appropriate maintainers. So,

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 10:05:28 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] I don't have much knowledge of the asoc architecture, so I probably can't comment much on the sound/ side design. For me the most important things are that 1) it works 2) I can easily unload/load the

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Tomi Valkeinen
Hi, On 13/11/14 11:17, Jean-Francois Moine wrote: On Thu, 13 Nov 2014 10:05:28 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] I don't have much knowledge of the asoc architecture, so I probably can't comment much on the sound/ side design. For me the most important things

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Jyri Sarha
On 11/13/2014 12:00 PM, Tomi Valkeinen wrote: Hi, On 13/11/14 11:17, Jean-Francois Moine wrote: On Thu, 13 Nov 2014 10:05:28 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: ... and I saw only a few dependencies between the 2 subsystems: - the CODEC must know the transmitter parameters

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 12:00:41 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] Jyri or Peter knows this better, but I think one difference with OMAP HDMI case and tda998x is that tda998x is an external encoder, and you transfer audio data to it via i2s or spdif, whereas OMAP

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Tomi Valkeinen
On 13/11/14 17:00, Jean-Francois Moine wrote: When the tda998x is not operational, the CODEC knows it and reports an error to the audio subsystem on device open. But, once the tda998x has been started, it always stays operational, even without HDMI connection. What does started mean here?

[PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-12 Thread Jyri Sarha
The patches are based on: git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git for-next The base, the patches, and couple of additional not-to-be-merged omap2plus_defconfig patches can be found here: https://github.com/jsarha/linux.git omap-hdmi-audio It would make the most sense to get

Re: [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-12 Thread Mark Brown
On Wed, Nov 12, 2014 at 04:40:51PM +0200, Jyri Sarha wrote: It would make the most sense to get these in trough fbdev tree. So it would be nice to get acked-bys (if the patches are Ok) for ASoC side changes from appropriate maintainers. So, this is a very large series which gets reposted