Re: [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits

2010-01-18 Thread Peter Ujfalusi
Hello Janusz, On Friday 15 January 2010 18:43:11 ext Janusz Krzysztofik wrote: --- git/arch/arm/plat-omap/mcbsp.c.orig2010-01-14 00:36:14.0 +0100 +++ git/arch/arm/plat-omap/mcbsp.c 2010-01-14 02:05:23.0 +0100 @@ -114,7 +114,8 @@ static irqreturn_t omap_mcbsp_tx_irq_han

Re: [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits

2010-01-18 Thread Jarkko Nikula
On Mon, 18 Jan 2010 10:05:12 +0200 Peter Ujfalusi peter.ujfal...@nokia.com wrote: What about introducing this simplification in a separate followup patch, quoting your rationale in its changelog? I can try to prepare one if you agree. I think it is OK to have a followup patch addressing

Re: [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits

2010-01-15 Thread Peter Ujfalusi
Hello, I think there are some inconsistency in a way how for example the SPCR1 and SPCR2 registers are used. On Thursday 14 January 2010 18:13:36 ext Janusz Krzysztofik wrote: Change the way McBSP registers are updated: use cached values instead of relying upon those read back from the

Re: [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits

2010-01-15 Thread Janusz Krzysztofik
Peter Ujfalusi wrote: Hello, Hi Peter, I think there are some inconsistency in a way how for example the SPCR1 and SPCR2 registers are used. On Thursday 14 January 2010 18:13:36 ext Janusz Krzysztofik wrote: Change the way McBSP registers are updated: use cached values instead of relying

[PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits

2010-01-14 Thread Janusz Krzysztofik
Change the way McBSP registers are updated: use cached values instead of relying upon those read back from the device. With this patch, I have finally managed to get rid of all random playback/recording hangups on my OMAP1510 based Amstrad Delta hardware. Before that, values read back from McBSP