On Sun, 27 Oct 2013 12:47:53 +0100, Pavel Machek pa...@ucw.cz wrote:
+#if IS_ENABLED(CONFIG_OF)
I'm probably missing something here, but why not #ifdef CONFIG_OF?
I have been told for other drivers, that IS_ENABLED() is
the prefered way to check for configuration these days.
On Wed 2013-10-30 06:53:07, Grant Likely wrote:
On Sun, 27 Oct 2013 12:47:53 +0100, Pavel Machek pa...@ucw.cz wrote:
+#if IS_ENABLED(CONFIG_OF)
I'm probably missing something here, but why not #ifdef CONFIG_OF?
I have been told for other drivers, that IS_ENABLED() is
the
On Oct 28, 2013, at 8:06 PM, Sebastian Reichel wrote:
On Mon, Oct 28, 2013 at 01:42:47AM -0500, Kumar Gala wrote:
+This binding is based on the matrix-keymap binding with the following
+changes:
Maybe be a bit more specific and say 'based on the input/matrix-keymap.txt
binding'..
OK.
On Tue, Oct 29, 2013 at 03:33:31AM -0500, Kumar Gala wrote:
On Oct 28, 2013, at 8:06 PM, Sebastian Reichel wrote:
On Mon, Oct 28, 2013 at 01:42:47AM -0500, Kumar Gala wrote:
+This binding is based on the matrix-keymap binding with the following
+changes:
Maybe be a bit more specific
On Oct 22, 2013, at 7:47 AM, Sebastian Reichel wrote:
Add device tree support for twl4030 keypad driver and update the
Documentation with twl4030 keypad device tree binding information.
Tested on Nokia N900.
Signed-off-by: Sebastian Reichel s...@debian.org
---
On Mon, Oct 28, 2013 at 01:42:47AM -0500, Kumar Gala wrote:
+This binding is based on the matrix-keymap binding with the following
+changes:
Maybe be a bit more specific and say 'based on the input/matrix-keymap.txt
binding'..
OK.
+ * keypad,num-rows and keypad,num-columns are
Hi!
Add device tree support for twl4030 keypad driver and update the
Documentation with twl4030 keypad device tree binding information.
Tested on Nokia N900.
It looks pretty good.
+++ b/Documentation/devicetree/bindings/input/twl4030-keypad.txt
@@ -0,0 +1,31 @@
+* TWL4030's Keypad
Hi Pavel,
On Sun, Oct 27, 2013 at 12:17:15PM +0100, Pavel Machek wrote:
Add device tree support for twl4030 keypad driver and update the
Documentation with twl4030 keypad device tree binding information.
Tested on Nokia N900.
It looks pretty good.
Thanks.
+ * keypad,num-rows and
Hi!
+ * keypad,num-rows and keypad,num-columns are required.
Is keypad, prefix neccessary here?
See Documentation/devicetree/bindings/input/matrix-keymap.txt
+Optional Properties specific to linux:
+- linux,keypad-no-autorepeat: do no enable autorepeat feature.
do not
* Pavel Machek pa...@ucw.cz [131027 04:48]:
+#if IS_ENABLED(CONFIG_OF)
I'm probably missing something here, but why not #ifdef CONFIG_OF?
I have been told for other drivers, that IS_ENABLED() is
the prefered way to check for configuration these days.
CONFIG_OF can not be module,
On Sun, Oct 27, 2013 at 05:23:48AM -0700, Tony Lindgren wrote:
* Pavel Machek pa...@ucw.cz [131027 04:48]:
+#if IS_ENABLED(CONFIG_OF)
I'm probably missing something here, but why not #ifdef CONFIG_OF?
I have been told for other drivers, that IS_ENABLED() is
the prefered way to
Add device tree support for twl4030 keypad driver and update the
Documentation with twl4030 keypad device tree binding information.
Tested on Nokia N900.
Signed-off-by: Sebastian Reichel s...@debian.org
---
.../devicetree/bindings/input/twl4030-keypad.txt | 31
12 matches
Mail list logo
