[PATCHv6 4/6] regulator: twl: fix twl4030 support for smps regulators

2011-11-25 Thread Tero Kristo
SMPS regulator voltage control differs from the one of the LDO ones. Current TWL code was using LDO regulator ops for controlling the SMPS regulators, which fails. This was fixed fixed by adding separate regulator type which uses correct logic and calculations for the voltage levels.

Re: [PATCHv6 4/6] regulator: twl: fix twl4030 support for smps regulators

2011-11-25 Thread Mark Brown
On Fri, Nov 25, 2011 at 06:29:20PM +0200, Tero Kristo wrote: + struct twlreg_info *info = rdev_get_drvdata(rdev); + int vsel = DIV_ROUND_UP(min_uV - 60, 12500); + + pr_info(attempting to write: %02x\n, vsel); There's lots of prints in the driver which are at most dev_dbg().

Re: [PATCHv6 4/6] regulator: twl: fix twl4030 support for smps regulators

2011-11-25 Thread Tero Kristo
On Fri, 2011-11-25 at 16:55 +, Mark Brown wrote: On Fri, Nov 25, 2011 at 06:29:20PM +0200, Tero Kristo wrote: + struct twlreg_info *info = rdev_get_drvdata(rdev); + int vsel = DIV_ROUND_UP(min_uV - 60, 12500); + + pr_info(attempting to write: %02x\n, vsel); There's lots