[RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Sourav Poddar
smsc can be used as an gpio io expander device also. So adding support for configuring smsc pins as a gpio. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- drivers/gpio/Kconfig

Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Felipe Balbi
Hi, On Tue, Aug 21, 2012 at 04:15:40PM +0530, Sourav Poddar wrote: smsc can be used as an gpio io expander device also. So adding support for configuring smsc pins as a gpio. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com

Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Poddar, Sourav
Hi, On Tue, Aug 21, 2012 at 4:23 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Aug 21, 2012 at 04:15:40PM +0530, Sourav Poddar wrote: smsc can be used as an gpio io expander device also. So adding support for configuring smsc pins as a gpio. Cc: Benoit Cousson b-cous...@ti.com Cc:

Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Felipe Balbi
Hi, On Tue, Aug 21, 2012 at 05:17:37PM +0530, Poddar, Sourav wrote: + if (type IRQ_TYPE_LEVEL_HIGH) + sg-int_lvl[bank] |= bit; + else if (type IRQ_TYPE_LEVEL_LOW) + sg-int_lvl[bank] = ~bit; + else + return -EINVAL; this looks

Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Poddar, Sourav
Hi, On Tue, Aug 21, 2012 at 5:30 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Aug 21, 2012 at 05:17:37PM +0530, Poddar, Sourav wrote: + if (type IRQ_TYPE_LEVEL_HIGH) + sg-int_lvl[bank] |= bit; + else if (type IRQ_TYPE_LEVEL_LOW) + sg-int_lvl[bank]

Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Felipe Balbi
On Tue, Aug 21, 2012 at 05:50:28PM +0530, Poddar, Sourav wrote: Hi, On Tue, Aug 21, 2012 at 5:30 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Aug 21, 2012 at 05:17:37PM +0530, Poddar, Sourav wrote: + if (type IRQ_TYPE_LEVEL_HIGH) + sg-int_lvl[bank] |= bit; +

Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-08-21 Thread Mark Brown
On Tue, Aug 21, 2012 at 03:22:18PM +0300, Felipe Balbi wrote: On Tue, Aug 21, 2012 at 05:50:28PM +0530, Poddar, Sourav wrote: If I am understanding correctly, if they both uses the same bit we cannot use both for a particular user. ? we can, it's just a bit more complex. If a user request