Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-30 Thread Koen Kooi
Op 29 mei 2011, om 23:04 heeft Steve Calfee het volgende geschreven: > For instance Beagleboard xm uboot > cannot access the ethernet because it is usb based, and uboot cannot > access its own environment in flash - because it is running from a new > microsd based flash system. U-boot has suppo

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-30 Thread Cousson, Benoit
On 5/29/2011 11:04 PM, Steve Calfee wrote: On Fri, May 27, 2011 at 12:38 PM, Kevin Hilman wrote: "Cousson, Benoit" writes: [...] In general we do not want to reset nor idle an IP that was potentially already properly configured by bootloader or early Linux boot code. Actually, the opposit

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-29 Thread Steve Calfee
On Fri, May 27, 2011 at 12:38 PM, Kevin Hilman wrote: > "Cousson, Benoit" writes: > > [...] > >> In general we do not want to reset nor idle an IP that was potentially >> already properly configured by bootloader or early Linux boot code. > > Actually, the opposite is true. > > The kernel should

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-28 Thread Menon, Nishanth
On Fri, May 27, 2011 at 14:38, Kevin Hilman wrote: > > "Cousson, Benoit" writes: > > [...] > > > In general we do not want to reset nor idle an IP that was potentially > > already properly configured by bootloader or early Linux boot code. > > Actually, the opposite is true. > > The kernel should

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-27 Thread Kevin Hilman
"Cousson, Benoit" writes: [...] > In general we do not want to reset nor idle an IP that was potentially > already properly configured by bootloader or early Linux boot code. Actually, the opposite is true. The kernel should not make any assumptions about what the bootloader has or has not don

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-27 Thread Kevin Hilman
"Cousson, Benoit" writes: > Hi Kevin, > > On 5/27/2011 4:59 PM, Hilman, Kevin wrote: >> Govindraj writes: > > [...] > >>> uart->oh->flags |= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET; >>> >> >> This is a hack (written by me) because the UART driver is not runtime PM >> adapted. When UART driver

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-27 Thread Cousson, Benoit
Hi Kevin, On 5/27/2011 4:59 PM, Hilman, Kevin wrote: Govindraj writes: [...] uart->oh->flags |= HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET; This is a hack (written by me) because the UART driver is not runtime PM adapted. When UART driver is runtime PM adapted, this will not be needed.

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-27 Thread Kevin Hilman
Govindraj writes: > On Fri, May 27, 2011 at 12:40 PM, Cousson, Benoit wrote: > > On 5/27/2011 1:24 AM, Hilman, Kevin wrote: > > Nishanth Menon  writes: > > > From: Moiz Sonasath > > For OMAP4460, GPIO-7 of bank1 is used for controling > the TPS mod

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-27 Thread Cousson, Benoit
On 5/27/2011 9:26 AM, Govindraj wrote: On Fri, May 27, 2011 at 12:40 PM, Cousson, Benoit mailto:b-cous...@ti.com>> wrote: On 5/27/2011 1:24 AM, Hilman, Kevin wrote: Nishanth Menonmailto:n...@ti.com>> writes: From: Moiz Sonasathmailto:m-sonas...@ti.com>> F

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-27 Thread Cousson, Benoit
On 5/27/2011 1:24 AM, Hilman, Kevin wrote: Nishanth Menon writes: From: Moiz Sonasath For OMAP4460, GPIO-7 of bank1 is used for controling the TPS modes, hence GPIO1 should not be reset during init as reset will cause the TPS voltage to drop to 0.9 V. ouch. I knew one of these days somethi

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 16:24, Kevin Hilman wrote: > Nishanth Menon writes: > >> From: Moiz Sonasath >> >> For OMAP4460, GPIO-7 of bank1 is used for controling >> the TPS modes, hence GPIO1 should not be reset >> during init as reset will cause the TPS voltage to >> drop to 0.9 V. > > ouch.  I k

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Kevin Hilman
Nishanth Menon writes: > From: Moiz Sonasath > > For OMAP4460, GPIO-7 of bank1 is used for controling > the TPS modes, hence GPIO1 should not be reset > during init as reset will cause the TPS voltage to > drop to 0.9 V. ouch. I knew one of these days something like this was going to happen wi

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Nishanth Menon
Cc: Sonasath, Moiz; Menon, Nishanth > > Subject: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 > > during HWMOD init > > [sp] typo in the subject. "DO" -> "Do" > > Another nit: Are 2 HWMODs required in the subject? :) thanks. will fix. -- R

RE: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Premi, Sanjeev
> -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth > Sent: Thursday, May 26, 2011 7:27 AM > To: linux-omap > Cc: Sonasath, Moiz; Menon, Nishanth > Subject: [RFC][PATCH 3/9] OMAP4460

[RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-25 Thread Nishanth Menon
From: Moiz Sonasath For OMAP4460, GPIO-7 of bank1 is used for controling the TPS modes, hence GPIO1 should not be reset during init as reset will cause the TPS voltage to drop to 0.9 V. Originally from: http://git.omapzoom.org/?p=kernel/omap.git;a=commitdiff;h=52ae4f0de03b17c064d9ce90a580230f1a5