RE: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Gadiyar, Anand
Felipe Balbi wrote: > Hi, > > On Fri, Aug 20, 2010 at 07:47:07AM +0200, ext Gadiyar, Anand wrote: > >The differences between OMAP3 and OMAP4 are: > >- The OMAP4 has a different set of clocks which do not exist > on OMAP3. > >- The register bits for configuring port modes is different > > is it a

RE: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Gadiyar, Anand
Felipe Balbi wrote: > Hi, > > On Fri, Aug 20, 2010 at 07:47:07AM +0200, ext Gadiyar, Anand wrote: > >The differences between OMAP3 and OMAP4 are: > >- The OMAP4 has a different set of clocks which do not exist on OMAP3. > >- The register bits for configuring port modes is different > > is it a di

RE: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Shilimkar, Santosh
el.org; linux-omap@vger.kernel.org > Subject: RE: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support > > Felipe Balbi wrote: > > On Thu, Aug 19, 2010 at 01:49:33AM +0200, ext Keshava Munegowda wrote: > > >@@ -298,7 +327,163 @@ static int omap_start_ehc(struct ehci_hc &

Re: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Felipe Balbi
Hi, On Fri, Aug 20, 2010 at 07:47:07AM +0200, ext Gadiyar, Anand wrote: The differences between OMAP3 and OMAP4 are: - The OMAP4 has a different set of clocks which do not exist on OMAP3. - The register bits for configuring port modes is different is it a different ip core or just a modificati

RE: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Gadiyar, Anand
Felipe Balbi wrote: > On Thu, Aug 19, 2010 at 01:49:33AM +0200, ext Keshava Munegowda wrote: > >@@ -298,7 +327,163 @@ static int omap_start_ehc(struct ehci_hc > > } > > > > if (cpu_is_omap44xx()) { > >-/* TODO */ > > driver should never make use of cpu_is_omap* calls neither ma

Re: [RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Felipe Balbi
Hi, On Thu, Aug 19, 2010 at 01:49:33AM +0200, ext Keshava Munegowda wrote: @@ -298,7 +327,163 @@ static int omap_start_ehc(struct ehci_hc } if (cpu_is_omap44xx()) { - /* TODO */ driver should never make use of cpu_is_omap* calls neither machine_is_* for that mat

[RFC] [PATCH 3/7] usb: ehci-omap: omap: Add OMAP4 support

2010-08-19 Thread Keshava Munegowda
Update the ehci-omap driver to add support for OMAP4. The OMAP4 has two ports compared to 3 on the OMAP3. Each port has its own functional clock, compared to a single clock for all ports on OMAP3. The clock can be internally sourced (TLL mode, HSIC mode), or externally provided (ULPI PHY). Regis