[RFC] dt: export of_have_populated_dt

2012-04-10 Thread Balaji T K
If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt. Signed-off-by: Balaji T K balaj...@ti.com --- drivers/of/base.c |6 ++ include/linux/of.h |6 +- 2 files changed, 7 insertions(+), 5

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Cousson, Benoit
Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt. Is this function really called from the MMC driver? Regards, Benoit Signed-off-by: Balaji T

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Chris Ball
Hi, On Tue, Apr 10 2012, Cousson, Benoit wrote: Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt. Is this function really called from the MMC driver?

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Cousson, Benoit
Hi Chris, On 4/10/2012 6:21 PM, Chris Ball wrote: Hi, On Tue, Apr 10 2012, Cousson, Benoit wrote: Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt.

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Rob Herring
On 04/10/2012 11:29 AM, Cousson, Benoit wrote: Hi Chris, On 4/10/2012 6:21 PM, Chris Ball wrote: Hi, On Tue, Apr 10 2012, Cousson, Benoit wrote: Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error,

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Sebastian Andrzej Siewior
On 04/10/2012 05:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt. Why do you need this function at all? You should not need it. *I* introduced it because I need it early x86

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Grant Likely
On Tue, 10 Apr 2012 12:20:27 -0500, Rob Herring robherri...@gmail.com wrote: On 04/10/2012 11:29 AM, Cousson, Benoit wrote: Hi Chris, On 4/10/2012 6:21 PM, Chris Ball wrote: Hi, On Tue, Apr 10 2012, Cousson, Benoit wrote: Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Rajendra Nayak
On Tuesday 10 April 2012 10:50 PM, Rob Herring wrote: Rob, Does it make sense to use that in the driver? So far I was using that only in the arch code to make the difference between the DT boot and the non-DT boot. I guess that a driver should rely on of_match_device or non-NULL

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Rajendra Nayak
On Tuesday 10 April 2012 08:41 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with allnodes undefined error, so remove inline and export of_have_populated_dt. Thanks Balaji, for taking care of this while I was out. But like Rob and Sebastian mentioned, looks