Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-22 Thread Arnd Bergmann
On Tuesday 22 April 2014, Javier Martinez Canillas wrote: > Hello Linus, > > On Tue, Apr 22, 2014 at 1:36 PM, Linus Walleij > wrote: > > On Tue, Apr 8, 2014 at 8:20 PM, Javier Martinez Canillas > > wrote: > > > >> So this is an RFC patch-set to add a virtual table to be used by > >> GPIO chip c

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-22 Thread Javier Martinez Canillas
Hello Linus, On Tue, Apr 22, 2014 at 1:36 PM, Linus Walleij wrote: > On Tue, Apr 8, 2014 at 8:20 PM, Javier Martinez Canillas > wrote: > >> So this is an RFC patch-set to add a virtual table to be used by >> GPIO chip controllers and consist of the following patches: > > Overall I like this. > >

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-22 Thread Linus Walleij
On Tue, Apr 8, 2014 at 8:20 PM, Javier Martinez Canillas wrote: > So this is an RFC patch-set to add a virtual table to be used by > GPIO chip controllers and consist of the following patches: Overall I like this. However I don't want to see any transitional phase. I prefer a BIG fat patch conv

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-10 Thread Javier Martinez Canillas
Hello Andy, On Thu, Apr 10, 2014 at 1:00 PM, Andy Shevchenko wrote: > On Thu, 2014-04-10 at 11:34 +0200, Javier Martinez Canillas wrote: >> On 04/10/2014 09:36 AM, Alexandre Courbot wrote: >> > >> > "Since having the operations" maybe? >> > >> >> Yes, since I'm not a native english speaker I some

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-10 Thread Andy Shevchenko
On Thu, 2014-04-10 at 11:34 +0200, Javier Martinez Canillas wrote: > On 04/10/2014 09:36 AM, Alexandre Courbot wrote: > > > > "Since having the operations" maybe? > > > > Yes, since I'm not a native english speaker I sometimes miss some obvious > grammatical errors. I'll fix those when posting t

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-10 Thread Javier Martinez Canillas
Hello Alexandre, Thanks a lot for your feedback. On 04/10/2014 09:36 AM, Alexandre Courbot wrote: > On Wed, Apr 9, 2014 at 3:20 AM, Javier Martinez Canillas > wrote: >> In the kernel there are basically two patterns to implement object >> oriented code in C. You can either embedded a set of func

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-10 Thread Alexandre Courbot
On Wed, Apr 9, 2014 at 3:20 AM, Javier Martinez Canillas wrote: > In the kernel there are basically two patterns to implement object > oriented code in C. You can either embedded a set of function pointers s/embedded/embed > in a struct along with other members or have a separate virtual functio

[RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-08 Thread Javier Martinez Canillas
In the kernel there are basically two patterns to implement object oriented code in C. You can either embedded a set of function pointers in a struct along with other members or have a separate virtual function table (vtable) structure that hold all the functions and only store a pointer to that vt