Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-22 Thread Felipe Balbi
Hi, On Mon, Aug 22, 2011 at 09:59:46AM +0530, J, KEERTHY wrote: +static const struct dev_pm_ops omap_temp_sensor_dev_pm_ops = { +     .suspend = omap_temp_sensor_suspend, +     .resume = omap_temp_sensor_resume, +     .runtime_suspend = omap_temp_sensor_runtime_suspend, +    

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-21 Thread J, KEERTHY
On Thu, Aug 18, 2011 at 5:07 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Aug 18, 2011 at 04:22:15PM +0530, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-21 Thread J, KEERTHY
On Fri, Aug 19, 2011 at 11:04 AM, Todd Poynor toddpoy...@google.com wrote: On Thu, Aug 18, 2011 at 04:22:15PM +0530, Keerthy wrote: ... +static int omap_temp_sensor_clk_enable(struct omap_temp_sensor *temp_sensor) +{ +     u32 ret = 0; + +     if (temp_sensor-clk_on) { +            

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread J, KEERTHY
On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread Guenter Roeck
On Fri, Aug 19, 2011 at 02:04:58AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread J, KEERTHY
On Fri, Aug 19, 2011 at 11:34 AM, J, KEERTHY j-keer...@ti.com wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread J, KEERTHY
On Fri, Aug 19, 2011 at 11:34 AM, J, KEERTHY j-keer...@ti.com wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread J, KEERTHY
On Fri, Aug 19, 2011 at 11:47 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Fri, Aug 19, 2011 at 02:04:58AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-19 Thread Guenter Roeck
On Fri, Aug 19, 2011 at 09:01:53AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 11:47 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On Fri, Aug 19, 2011 at 02:04:58AM -0400, J, KEERTHY wrote: On Fri, Aug 19, 2011 at 7:43 AM, Guenter Roeck guenter.ro...@ericsson.com wrote: On

[RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-18 Thread Keerthy
On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user is allowed to configure the temperature thresholds vis sysfs

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-18 Thread Felipe Balbi
Hi, On Thu, Aug 18, 2011 at 04:22:15PM +0530, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-18 Thread Guenter Roeck
On Thu, Aug 18, 2011 at 06:52:15AM -0400, Keerthy wrote: On chip temperature sensor driver. The driver monitors the temperature of the MPU subsystem of the OMAP4. It sends notifications to the user space if the temperature crosses user defined thresholds via kobject_uevent interface. The user

Re: [RFC PATCH 6/6 V2] hwmon: OMAP4: On die temperature sensor driver

2011-08-18 Thread Todd Poynor
On Thu, Aug 18, 2011 at 04:22:15PM +0530, Keerthy wrote: ... +static int omap_temp_sensor_clk_enable(struct omap_temp_sensor *temp_sensor) +{ + u32 ret = 0; + + if (temp_sensor-clk_on) { + dev_err(temp_sensor-hwmon_dev, clock already on\n); + goto out; +