RE: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-04-04 Thread Bedia, Vaibhav
Hi Daniel, On Wed, Apr 03, 2013 at 17:22:41, Daniel Mack wrote: Hi Vaibhav, On Mon, Dec 31, 2012 at 2:07 PM, Vaibhav Bedia vaibhav.be...@ti.com wrote: AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @

Re: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-04-03 Thread Daniel Mack
Hi Vaibhav, On Mon, Dec 31, 2012 at 2:07 PM, Vaibhav Bedia vaibhav.be...@ti.com wrote: AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @ http://www.ti.com/litv/pdf/spruh73f May I ask about the plans for this series? Will you be

RE: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-02-20 Thread Bedia, Vaibhav
On Mon, Feb 18, 2013 at 21:41:49, Kevin Hilman wrote: [...] By default these IPs don't have MSTANDBY asserted. When you say by default, I guess you mean after reset (and/or context loss), right? Yes When a low power transition happens, the peripheral power domain loses context and

Re: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-02-20 Thread Kevin Hilman
Bedia, Vaibhav vaibhav.be...@ti.com writes: [...] IMO, this would be a much cleaner implementation if you just created a small driver for the wkup_m3. You're already doing a bunch of driver-like stuff for it (requesting base/IRQs, mapping regions, firmware, etc.) I think this should

Re: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-02-18 Thread Kevin Hilman
Bedia, Vaibhav vaibhav.be...@ti.com writes: Hi Kevin, On Tue, Feb 12, 2013 at 06:57:50, Kevin Hilman wrote: [...] + +void (*am33xx_do_wfi_sram)(void); static? Will fix. [...] + + /* + * By default the following IPs do not have MSTANDBY asserted + * which is necessary

RE: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-02-13 Thread Bedia, Vaibhav
Hi Kevin, On Tue, Feb 12, 2013 at 06:57:50, Kevin Hilman wrote: [...] + +void (*am33xx_do_wfi_sram)(void); static? Will fix. [...] + + /* +* By default the following IPs do not have MSTANDBY asserted +* which is necessary for PER domain transition. If the drivers +

Re: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-02-11 Thread Kevin Hilman
Hi Viabhav, Vaibhav Bedia vaibhav.be...@ti.com writes: AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @ http://www.ti.com/litv/pdf/spruh73f DeepSleep0 mode offers the lowest power mode with limited wakeup sources without a

Re: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-01-22 Thread Peter Korsgaard
V == Bedia, Vaibhav vaibhav.be...@ti.com writes: Hi, V + memcpy((void *)wkup_m3_context-code, fw-data, fw-size); A size check would be good. I don't know much about the finer details about the m3 and how it is connected, but don't you need to ensure data is flushed before resetting

RE: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-01-21 Thread Bedia, Vaibhav
Hi Peter, On Thu, Jan 17, 2013 at 19:57:20, Peter Korsgaard wrote: V == Vaibhav Bedia vaibhav.be...@ti.com writes: Hi, V +static void am33xx_pm_firmware_cb(const struct firmware *fw, void *context) V +{ V + struct wkup_m3_context *wkup_m3_context = context; V + struct

Re: [RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2013-01-17 Thread Peter Korsgaard
V == Vaibhav Bedia vaibhav.be...@ti.com writes: Hi, V +static void am33xx_pm_firmware_cb(const struct firmware *fw, void *context) V +{ V + struct wkup_m3_context *wkup_m3_context = context; V + struct platform_device *pdev = to_platform_device(wkup_m3_context-dev); V + int ret = 0;

[RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-12-31 Thread Vaibhav Bedia
AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @ http://www.ti.com/litv/pdf/spruh73f DeepSleep0 mode offers the lowest power mode with limited wakeup sources without a system reboot and is mapped as the suspend state in the kernel. In