On Wed, Jul 22, 2009 at 09:18:05PM +0200, Janusz Krzysztofik wrote:
After all, I am not sure what your preferences finally are. If you still
think
that exporting gpio based jack state from ASoC framework over gpiolib sysfs
doesn't hurt and can be usefull, I'll remove the code from my
On Wed, Jul 22, 2009 at 05:22:59AM +0200, Janusz Krzysztofik wrote:
Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl
---
CPU DAI parameters best matching the codec DAI has been selected out
empirically for best user experience.
Again, all the documentation you've got here could quite
At Wed, 22 Jul 2009 12:03:28 +0100,
Mark Brown wrote:
+ /* Setup pins after corresponding bits if changed */
+ if ((bool)snd_soc_dapm_get_pin_status(codec, Speaker) !=
+ (bool)(function (1 AMS_DELTA_SPEAKER))) {
Don't like these casts... why are they needed?
On Wed, Jul 22, 2009 at 01:39:22PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
+ /* Setup pins after corresponding bits if changed */
+ if ((bool)snd_soc_dapm_get_pin_status(codec, Speaker) !=
+ (bool)(function (1 AMS_DELTA_SPEAKER))) {
Don't like these casts...
Hi Mark,
Mark Brown wrote:
On Wed, Jul 22, 2009 at 05:22:59AM +0200, Janusz Krzysztofik wrote:
Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl
---
CPU DAI parameters best matching the codec DAI has been selected out
empirically for best user experience.
Again, all the documentation
Mark Brown wrote:
On Wed, Jul 22, 2009 at 01:39:22PM +0200, Takashi Iwai wrote:
Mark Brown wrote:
+ /* Setup pins after corresponding bits if changed */
+ if ((bool)snd_soc_dapm_get_pin_status(codec, Speaker) !=
+ (bool)(function (1 AMS_DELTA_SPEAKER))) {
On Wed, Jul 22, 2009 at 04:53:12PM +0200, Janusz Krzysztofik wrote:
Mark Brown wrote:
+#include sound/jack.h
ASoC will pull that one in for you, not that it really matters.
Maybe it should, but without sound/jack.h I get:
sound/soc/omap/ams-delta.c:184: error: 'SND_JACK_MICROPHONE'
Hi,
Wednesday 22 July 2009 17:07:09 Mark Brown wrote:
On Wed, Jul 22, 2009 at 04:53:12PM +0200, Janusz Krzysztofik wrote:
Mark Brown wrote:
+#include sound/jack.h
ASoC will pull that one in for you, not that it really matters.
Maybe it should, but without sound/jack.h I get:
