Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-26 Thread mark gross
On Thu, Aug 25, 2011 at 04:17:31PM +0200, Rafael J. Wysocki wrote: On Thursday, August 25, 2011, Mark Brown wrote: On Tue, Aug 23, 2011 at 11:31:54PM +0200, Rafael J. Wysocki wrote: Perhaps. Still, that requires some policy to be put into drivers, which I don't think is entirely

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-26 Thread mark gross
On Fri, Aug 26, 2011 at 11:25:13AM +0900, MyungJoo Ham wrote: On Fri, Jul 1, 2011 at 12:11 AM, jean.pi...@newoldbits.com wrote: @@ -129,19 +146,19 @@ static const struct file_operations pm_qos_power_fops = {  /* unlocked internal variant */  static inline int pm_qos_get_value(struct

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-26 Thread Rafael J. Wysocki
On Friday, August 26, 2011, mark gross wrote: On Fri, Aug 26, 2011 at 11:25:13AM +0900, MyungJoo Ham wrote: On Fri, Jul 1, 2011 at 12:11 AM, jean.pi...@newoldbits.com wrote: @@ -129,19 +146,19 @@ static const struct file_operations pm_qos_power_fops = { /* unlocked internal variant

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-25 Thread Mark Brown
On Tue, Aug 23, 2011 at 11:31:54PM +0200, Rafael J. Wysocki wrote: Perhaps. Still, that requires some policy to be put into drivers, which I don't think is entirely correct. So, I don't really have the bandwidth to discuss this properly for at least the next week or so - is it possible to

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-25 Thread Rafael J. Wysocki
On Thursday, August 25, 2011, Mark Brown wrote: On Tue, Aug 23, 2011 at 11:31:54PM +0200, Rafael J. Wysocki wrote: Perhaps. Still, that requires some policy to be put into drivers, which I don't think is entirely correct. So, I don't really have the bandwidth to discuss this properly

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-25 Thread Jean Pihet
On Thu, Aug 25, 2011 at 4:17 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Thursday, August 25, 2011, Mark Brown wrote: On Tue, Aug 23, 2011 at 11:31:54PM +0200, Rafael J. Wysocki wrote: Perhaps.  Still, that requires some policy to be put into drivers, which I don't think is entirely

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-25 Thread Rafael J. Wysocki
On Thursday, August 25, 2011, Jean Pihet wrote: On Thu, Aug 25, 2011 at 4:17 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Thursday, August 25, 2011, Mark Brown wrote: On Tue, Aug 23, 2011 at 11:31:54PM +0200, Rafael J. Wysocki wrote: Perhaps. Still, that requires some policy to be put

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-25 Thread MyungJoo Ham
On Fri, Jul 1, 2011 at 12:11 AM, jean.pi...@newoldbits.com wrote: @@ -129,19 +146,19 @@ static const struct file_operations pm_qos_power_fops = {  /* unlocked internal variant */  static inline int pm_qos_get_value(struct pm_qos_object *o)  { -       if (plist_head_empty(o-requests)) +    

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-23 Thread Mark Brown
On Sun, Aug 21, 2011 at 08:05:53PM +0200, Rafael J. Wysocki wrote: On Sunday, August 21, 2011, Mark Brown wrote: I don't understand why the driver would need to know what situation it's in. I'd been working on the basis that the idea was that the driver said what the constraints it has

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-23 Thread Rafael J. Wysocki
On Tuesday, August 23, 2011, Mark Brown wrote: On Sun, Aug 21, 2011 at 08:05:53PM +0200, Rafael J. Wysocki wrote: On Sunday, August 21, 2011, Mark Brown wrote: I don't understand why the driver would need to know what situation it's in. I'd been working on the basis that the idea was

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-21 Thread Mark Brown
On Sat, Aug 20, 2011 at 09:14:37PM +0200, Rafael J. Wysocki wrote: I guess you mean the driver here and I'm not really sure it can. For instance, the driver may not know what configuration it works in, e.g. is there a power domain or a hierarchy of those and how much time it takes to power

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-21 Thread Rafael J. Wysocki
On Sunday, August 21, 2011, Mark Brown wrote: On Sat, Aug 20, 2011 at 09:14:37PM +0200, Rafael J. Wysocki wrote: I guess you mean the driver here and I'm not really sure it can. For instance, the driver may not know what configuration it works in, e.g. is there a power domain or a

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Mark Brown
On Fri, Aug 19, 2011 at 10:24:19PM -0400, Alan Stern wrote: On Sat, 20 Aug 2011, Mark Brown wrote: interfaces and let the subsystem and driver translate these into actual wakeup latency constraints: https://lists.linux-foundation.org/pipermail/linux-pm/2011-August/032422.html

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Rafael J. Wysocki
On Saturday, August 20, 2011, Mark Brown wrote: On Fri, Aug 19, 2011 at 10:42:20PM +0200, Rafael J. Wysocki wrote: I really wouldn't like the discussion to go in circles. First, please tell me what in particular you are objecting to, because I don't think that's any of the patches that

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Mark Brown
On Sat, Aug 20, 2011 at 11:35:58AM +0200, Rafael J. Wysocki wrote: I'm not sure what you mean by exposing per-device wakeup latency constraints to user space. I simply thought it might be useful to allow user space to add and remove those, in analogy to what it can do with the currently

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Alan Stern
On Sat, 20 Aug 2011, Mark Brown wrote: On Fri, Aug 19, 2011 at 10:24:19PM -0400, Alan Stern wrote: On Sat, 20 Aug 2011, Mark Brown wrote: interfaces and let the subsystem and driver translate these into actual wakeup latency constraints:

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Mark Brown
On Sat, Aug 20, 2011 at 09:48:25AM -0400, Alan Stern wrote: No, I as wasking about driver- and subsystem-specific interfaces to userspace that translate into things users are already doing. Kevin's example was a touchscreen (although that was really an example of setting a power usage level,

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Rafael J. Wysocki
On Saturday, August 20, 2011, Mark Brown wrote: On Sat, Aug 20, 2011 at 09:48:25AM -0400, Alan Stern wrote: No, I as wasking about driver- and subsystem-specific interfaces to userspace that translate into things users are already doing. Kevin's example was a touchscreen (although that

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Rafael J. Wysocki
On Saturday, August 20, 2011, Mark Brown wrote: On Sat, Aug 20, 2011 at 11:35:58AM +0200, Rafael J. Wysocki wrote: I'm not sure what you mean by exposing per-device wakeup latency constraints to user space. I simply thought it might be useful to allow user space to add and remove

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Mark Brown
On Sat, Aug 20, 2011 at 06:34:34PM +0200, Rafael J. Wysocki wrote: On Saturday, August 20, 2011, Mark Brown wrote: Any sort of media streaming would be an obvious example - the application picks the amount of data it buffers and how often it's notified of progress depending on the usage

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Mark Brown
On Sat, Aug 20, 2011 at 06:51:42PM +0200, Rafael J. Wysocki wrote: On Saturday, August 20, 2011, Mark Brown wrote: Coming at this from the embedded perspective modifying the kernel just isn't an issue. It's quite depressing in other cases too but some of the circumstances you mentioned in

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Rafael J. Wysocki
On Saturday, August 20, 2011, Mark Brown wrote: On Sat, Aug 20, 2011 at 06:34:34PM +0200, Rafael J. Wysocki wrote: On Saturday, August 20, 2011, Mark Brown wrote: Any sort of media streaming would be an obvious example - the application picks the amount of data it buffers and how often

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-20 Thread Rafael J. Wysocki
On Saturday, August 20, 2011, Mark Brown wrote: On Sat, Aug 20, 2011 at 06:51:42PM +0200, Rafael J. Wysocki wrote: On Saturday, August 20, 2011, Mark Brown wrote: Coming at this from the embedded perspective modifying the kernel just isn't an issue. It's quite depressing in other cases

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-19 Thread Rafael J. Wysocki
Hi, I really wouldn't like the discussion to go in circles. First, please tell me what in particular you are objecting to, because I don't think that's any of the patches that have been sent to the linux-pm list to date. Thanks, Rafael -- To unsubscribe from this list: send the line unsubscribe

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-19 Thread Mark Brown
On Fri, Aug 19, 2011 at 10:42:20PM +0200, Rafael J. Wysocki wrote: I really wouldn't like the discussion to go in circles. First, please tell me what in particular you are objecting to, because I don't think that's any of the patches that have been sent to the linux-pm list to date. The

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-19 Thread Alan Stern
On Sat, 20 Aug 2011, Mark Brown wrote: The original issue that Kevin raised and CCed me in on was the idea of exposing raw per-device wakeup latency constraints to userspace; it seems much better to expose user level requirements via subsystem interfaces and let the subsystem and driver

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-18 Thread Mark Brown
On Mon, 2011-08-08 at 23:31 +0200, Rafael J. Wysocki wrote: On Sunday, August 07, 2011, Mark Brown wrote: OK, so this does sound like there's probably a genuine issue on PCs due to limitations in the environment. Is it possible to expose these things to userspace in a way that's limited

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-08 Thread Rafael J. Wysocki
On Sunday, August 07, 2011, Mark Brown wrote: On Sat, Aug 06, 2011 at 09:46:20PM +0200, Rafael J. Wysocki wrote: On Saturday, August 06, 2011, Mark Brown wrote: I wouldn't say we've got to rely on userspace here - it seems like we ought to be able to use DMI or other system data to

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-06 Thread Rafael J. Wysocki
On Saturday, August 06, 2011, Mark Brown wrote: On Fri, Aug 05, 2011 at 09:37:36PM +0200, Rafael J. Wysocki wrote: On Friday, August 05, 2011, Mark Brown wrote: Do you have any examples of this that aren't better expressed in device specific terms? I'm not sure what you mean

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-06 Thread Mark Brown
On Sat, Aug 06, 2011 at 09:46:20PM +0200, Rafael J. Wysocki wrote: On Saturday, August 06, 2011, Mark Brown wrote: I wouldn't say we've got to rely on userspace here - it seems like we ought to be able to use DMI or other system data to identify the affected systems and activate the

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-05 Thread mark gross
On Thu, Aug 04, 2011 at 09:15:30PM +0200, Rafael J. Wysocki wrote: On Thursday, August 04, 2011, Mark Brown wrote: On Wed, Aug 03, 2011 at 12:16:17AM +0200, Rafael J. Wysocki wrote: On Tuesday, August 02, 2011, Kevin Hilman wrote: I disagree and think that both are quite realistic

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-05 Thread Mark Brown
On Thu, Aug 04, 2011 at 09:15:30PM +0200, Rafael J. Wysocki wrote: On Thursday, August 04, 2011, Mark Brown wrote: On the one hand that's true. On the other hand that just seems like going down a bad road where we have drivers that only work when run with a magic userspace that may or may

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-05 Thread Rafael J. Wysocki
On Friday, August 05, 2011, Mark Brown wrote: On Thu, Aug 04, 2011 at 09:15:30PM +0200, Rafael J. Wysocki wrote: On Thursday, August 04, 2011, Mark Brown wrote: On the one hand that's true. On the other hand that just seems like going down a bad road where we have drivers that only

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-05 Thread Mark Brown
On Fri, Aug 05, 2011 at 09:37:36PM +0200, Rafael J. Wysocki wrote: On Friday, August 05, 2011, Mark Brown wrote: Do you have any examples of this that aren't better expressed in device specific terms? I'm not sure what you mean exactly, but if you take two PC-like systems with similar

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-04 Thread Mark Brown
On Wed, Aug 03, 2011 at 12:16:17AM +0200, Rafael J. Wysocki wrote: On Tuesday, August 02, 2011, Kevin Hilman wrote: I disagree and think that both are quite realistic (mainly because they exist today, albiet mostly out of tree because no generic QoS framework exist. e.g. on OMAP, we have

Re: [linux-pm] [PATCH 02/11] PM: extend PM QoS with per-device wake-up constraints

2011-08-04 Thread Rafael J. Wysocki
On Thursday, August 04, 2011, Mark Brown wrote: On Wed, Aug 03, 2011 at 12:16:17AM +0200, Rafael J. Wysocki wrote: On Tuesday, August 02, 2011, Kevin Hilman wrote: I disagree and think that both are quite realistic (mainly because they exist today, albiet mostly out of tree because no