Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-12 Thread Jonathan Cameron
Hi Chris, Obviously a few things will change with your move over to input, but as I have a few mins and might not then, here are a few comments. The ones I'd really like to see acted upon are *removing the global pointer that restricts you to one device (all hell will break loose if you add a

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-11 Thread Jonathan Cameron
Chris Hudson wrote: Jean Delvare wrote: On Tue, 10 Nov 2009 15:32:50 -0500, Chris Hudson wrote: Thank you for your insight Jonathan. The driver was originally written for the 2.6.29 omap-android kernel to facilitate integration of the kxte9 into customer projects. Unfortunately, it seems

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-11 Thread Chris Hudson
Jonathan Cameron wrote: Chris Hudson wrote: Jean Delvare wrote: On Tue, 10 Nov 2009 15:32:50 -0500, Chris Hudson wrote: Thank you for your insight Jonathan. The driver was originally written for the 2.6.29 omap-android kernel to facilitate integration of the kxte9 into

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-10 Thread Jean Delvare
On Tue, 10 Nov 2009 13:28:47 -0500, chud...@kionix.com wrote: From: Chris Hudson chud...@kionix.com This is a request for comments for adding driver support for the Kionix KXTE9 digital tri-axis accelerometer. This part features built-in tilt position (orientation), wake-up and

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-10 Thread Chris Hudson
Jean Delvare wrote: On Tue, 10 Nov 2009 13:28:47 -0500, chud...@kionix.com wrote: From: Chris Hudson chud...@kionix.com This is a request for comments for adding driver support for the Kionix KXTE9 digital tri-axis accelerometer. This part features built-in tilt position (orientation),

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-10 Thread Chris Hudson
Jonathan Cameron wrote: Chris Hudson wrote: Jean Delvare wrote: On Tue, 10 Nov 2009 13:28:47 -0500, chud...@kionix.com wrote: From: Chris Hudson chud...@kionix.com This is a request for comments for adding driver support for the Kionix KXTE9 digital tri-axis accelerometer.

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-10 Thread Jean Delvare
On Tue, 10 Nov 2009 15:32:50 -0500, Chris Hudson wrote: Thank you for your insight Jonathan. The driver was originally written for the 2.6.29 omap-android kernel to facilitate integration of the kxte9 into customer projects. Unfortunately, it seems that things in the kernel have changed

Re: [lm-sensors] [RFC PATCH 1/3] hwmon:driver support for Kionix kxte9 accelerometer

2009-11-10 Thread Chris Hudson
Jean Delvare wrote: On Tue, 10 Nov 2009 15:32:50 -0500, Chris Hudson wrote: Thank you for your insight Jonathan. The driver was originally written for the 2.6.29 omap-android kernel to facilitate integration of the kxte9 into customer projects. Unfortunately, it seems that things in the