Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-18 Thread Nicolas Ferre
On 10/17/2012 11:33 PM, Russell King - ARM Linux : On Wed, Oct 17, 2012 at 11:28:48PM +0300, Phil Carmody wrote: So, what to do? It can and has been used sensibly, so I don't think removing it is the best option. Well, the first thing that needs to be done is a full review of every user and

IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Russell King - ARM Linux
People, This is not aimed at anyone specifically - but it is aimed at everyone who reviews patches to make them aware of this issue, and to modify their behaviour. I'm geting sick and tired of telling people about this. I've just floated the idea of removing IS_ERR_OR_NULL from the kernel tree

Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Phil Carmody
On 17/10/12 20:41 +0100, Russell King - ARM Linux wrote: People, This is not aimed at anyone specifically - but it is aimed at everyone who reviews patches to make them aware of this issue, and to modify their behaviour. I'm geting sick and tired of telling people about this. I've just

Re: IS_ERR_OR_NULL - please STOP telling people to use this on a whim

2012-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2012 at 11:28:48PM +0300, Phil Carmody wrote: So, what to do? It can and has been used sensibly, so I don't think removing it is the best option. Well, the first thing that needs to be done is a full review of every user and fixes applied. The second thing is that we need eyes