Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-02-02 Thread Nicolas Pitre
On Mon, 2 Feb 2015, Pavel Machek wrote: > On Tue 2015-01-27 10:16:24, Nicolas Pitre wrote: > > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > > > > > > > > I would say, problem is because omap3-n900 binary DT is too large > > > > > > > > I agree. > > > > > > > > > OK if that's the case, then

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-02-02 Thread Pavel Machek
On Tue 2015-01-27 10:16:24, Nicolas Pitre wrote: > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > > > > > I would say, problem is because omap3-n900 binary DT is too large > > > > > > I agree. > > > > > > > OK if that's the case, then your patch makes sense to me. It also > > > > seems we can

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Pavel Machek
On Tue 2015-01-27 13:50:22, Nicolas Pitre wrote: > On Tue, 27 Jan 2015, Russell King - ARM Linux wrote: > > > On Tue, Jan 27, 2015 at 10:16:24AM -0500, Nicolas Pitre wrote: > > > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > (Note, that in 3.19 dts for n900 got too big, so we are actually > > >

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Aaro Koskinen
On Tue, Jan 27, 2015 at 01:50:22PM -0500, Nicolas Pitre wrote: > Hence the ATAG-to-DT compat code in the decompressor. This > was meant to smooth things around the transition to DT, etc. After all, > those devices with non-replaceable bootloaders where shim layers are not > possible should get

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Nicolas Pitre
On Tue, 27 Jan 2015, Russell King - ARM Linux wrote: > On Tue, Jan 27, 2015 at 10:16:24AM -0500, Nicolas Pitre wrote: > > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > (Note, that in 3.19 dts for n900 got too big, so we are actually > > > triggering old bugs. That means that this is a regression

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Russell King - ARM Linux
On Tue, Jan 27, 2015 at 10:16:24AM -0500, Nicolas Pitre wrote: > On Tue, 27 Jan 2015, Pavel Machek wrote: > > (Note, that in 3.19 dts for n900 got too big, so we are actually > > triggering old bugs. That means that this is a regression fix, and > > should go in ASAP). > > It is queued here: > htt

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Tony Lindgren
* Nicolas Pitre [150127 07:19]: > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > > > > > I would say, problem is because omap3-n900 binary DT is too large > > > > > > I agree. > > > > > > > OK if that's the case, then your patch makes sense to me. It also > > > > seems we can have the tempor

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Pali Rohár
On Tuesday 27 January 2015 16:16:24 Nicolas Pitre wrote: > On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > > I would say, problem is because omap3-n900 binary DT > > > > > is too large > > > > > > I agree. > > > > > > > OK if that's the case, then your patch makes sense to > > > > me. It also se

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Nicolas Pitre
On Tue, 27 Jan 2015, Pavel Machek wrote: > > > > > I would say, problem is because omap3-n900 binary DT is too large > > > > I agree. > > > > > OK if that's the case, then your patch makes sense to me. It also > > > seems we can have the temporary stack be larger than the initial > > > stack ju

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-27 Thread Pavel Machek
> > > I would say, problem is because omap3-n900 binary DT is too large > > I agree. > > > OK if that's the case, then your patch makes sense to me. It also > > seems we can have the temporary stack be larger than the initial > > stack just for atags_to_fdt. > > The stack size isn't the issue,

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-26 Thread Nicolas Pitre
On Mon, 26 Jan 2015, Pavel Machek wrote: > Hi! > > > > > $ du -b arch/arm/boot/dts/omap3-n900.dtb > > > > 70212 arch/arm/boot/dts/omap3-n900.dtb > > > > > > > > $ echo $((0x1)) > > > > 65536 > > > > > > > > I would say, problem is because omap3-n900 binary DT is too large > > > > I agre

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-26 Thread Pavel Machek
Hi! > > > $ du -b arch/arm/boot/dts/omap3-n900.dtb > > > 70212 arch/arm/boot/dts/omap3-n900.dtb > > > > > > $ echo $((0x1)) > > > 65536 > > > > > > I would say, problem is because omap3-n900 binary DT is too large > > I agree. > > > OK if that's the case, then your patch makes sense to

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-26 Thread Nicolas Pitre
On Mon, 26 Jan 2015, Tony Lindgren wrote: > * Pali Rohár [150126 08:26]: > > On Monday 26 January 2015 17:14:55 Tony Lindgren wrote: > > > * Pali Rohár [150123 14:39]: > > > > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > > > > Hello, > > > > > > > > > > when I boot zImage with appen

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-26 Thread Tony Lindgren
* Pali Rohár [150126 08:26]: > On Monday 26 January 2015 17:14:55 Tony Lindgren wrote: > > * Pali Rohár [150123 14:39]: > > > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > > > Hello, > > > > > > > > when I boot zImage with appended DT n900 in qemu > > > > fdt_open_into() function call

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-26 Thread Pali Rohár
On Monday 26 January 2015 17:14:55 Tony Lindgren wrote: > * Pali Rohár [150123 14:39]: > > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > > Hello, > > > > > > when I boot zImage with appended DT n900 in qemu > > > fdt_open_into() function called from file > > > arch/arm/boot/compressed/

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-26 Thread Tony Lindgren
* Pali Rohár [150123 14:39]: > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > Hello, > > > > when I boot zImage with appended DT n900 in qemu > > fdt_open_into() function called from file > > arch/arm/boot/compressed/atags_to_fdt.c (in function > > atags_to_fdt) always returns -FDT_ERR_

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-24 Thread Pali Rohár
On Saturday 24 January 2015 00:48:55 Pavel Machek wrote: > On Fri 2015-01-23 23:36:36, Pali Rohár wrote: > > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > > Hello, > > > > > > when I boot zImage with appended DT n900 in qemu > > > fdt_open_into() function called from file > > > arch/arm

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-23 Thread Pavel Machek
On Fri 2015-01-23 23:36:36, Pali Rohár wrote: > On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > > Hello, > > > > when I boot zImage with appended DT n900 in qemu > > fdt_open_into() function called from file > > arch/arm/boot/compressed/atags_to_fdt.c (in function > > atags_to_fdt) always r

Re: N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-23 Thread Pali Rohár
On Friday 23 January 2015 22:39:55 Pali Rohár wrote: > Hello, > > when I boot zImage with appended DT n900 in qemu > fdt_open_into() function called from file > arch/arm/boot/compressed/atags_to_fdt.c (in function > atags_to_fdt) always returns -FDT_ERR_NOSPACE. > > It means that all ATAGS (inclu

N900 v3.19-rc5 arm atags_to_fdt.c is broken

2015-01-23 Thread Pali Rohár
Hello, when I boot zImage with appended DT n900 in qemu fdt_open_into() function called from file arch/arm/boot/compressed/atags_to_fdt.c (in function atags_to_fdt) always returns -FDT_ERR_NOSPACE. It means that all ATAGS (including cmdline arguments) passed by bootloader are ignored. On real