From: Eric Dumazet eric.duma...@gmail.com
Date: Wed, 26 May 2010 22:48:53 +0200
Le mercredi 26 mai 2010 à 15:19 -0500, Arce, Abraham a écrit :
By increasing the allocation length of our rx skbuff the corruption issue is
fixed... I have increased it by 2... Were we writing outside our
Thanks Eric, David,
[..]
- if (skb_shinfo(skb)-nr_frags) {
+ if (skb_shinfo(skb)-nr_frags skb_has_frags(skb)) {
int i;
for (i = 0; i skb_shinfo(skb)-nr_frags; i++)
Le mercredi 26 mai 2010 à 15:19 -0500, Arce, Abraham a écrit :
By increasing the allocation length of our rx skbuff the corruption issue is
fixed... I have increased it by 2... Were we writing outside our boundaries
of skb data?
Please let me know about this approach...
diff --git
Hi,
I am able to avoid the NULL pointer dereference but not sure if the handling
is the correct one... find the patch below...
I have 2 scenarios in which I am getting a NULL pointer dereference:
1) root filesystem over nfs
2) telnet connection
The issue appeared on this commit
From: Arce, Abraham x0066...@ti.com
Date: Tue, 25 May 2010 20:48:02 -0500
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f8abf68..eb81f76 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -334,7 +334,7 @@ static void skb_release_data(struct sk_buff *skb)
if
Thanks David,
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f8abf68..eb81f76 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -334,7 +334,7 @@ static void skb_release_data(struct sk_buff *skb)
if (!skb-cloned ||
!atomic_sub_return(skb-nohdr ? (1
Le mardi 25 mai 2010 à 21:02 -0500, Arce, Abraham a écrit :
Thanks David,
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index f8abf68..eb81f76 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -334,7 +334,7 @@ static void skb_release_data(struct sk_buff *skb)
if