Re: OMAP4 DSS clock setup

2011-04-12 Thread Tomi Valkeinen
On Mon, 2011-04-11 at 12:20 -0600, Paul Walmsley wrote: Hi On Mon, 11 Apr 2011, Tomi Valkeinen wrote: However, I think there is one difference between the clock used just to enable the DSS registers, and the one used to output pixels: we need to be able to adjust the rate of the clock.

Re: OMAP4 DSS clock setup

2011-04-12 Thread Tomi Valkeinen
On Mon, 2011-04-11 at 10:05 -0600, Paul Walmsley wrote: Hi On Mon, 11 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-08 at 10:28 -0600, Paul Walmsley wrote: On Fri, 8 Apr 2011, Tomi Valkeinen wrote: Also, I hope you and the other DSS hackers can finish the PM runtime

Re: OMAP4 DSS clock setup

2011-04-11 Thread Tomi Valkeinen
On Fri, 2011-04-08 at 10:28 -0600, Paul Walmsley wrote: Hi Tomi, On Fri, 8 Apr 2011, Tomi Valkeinen wrote: Also, I hope you and the other DSS hackers can finish the PM runtime conversion of the DSS driver soon. Ideally before any new DSS features are added. We really need to be

Re: OMAP4 DSS clock setup

2011-04-11 Thread Tomi Valkeinen
On Fri, 2011-04-08 at 08:55 -0600, Paul Walmsley wrote: Hi On Fri, 8 Apr 2011, Tomi Valkeinen wrote: and not the clock used for the pixel clock? If so, I'm fine with having fck to be what it is currently, but then we need a new name for the clock used for pixel clock, which is

Re: OMAP4 DSS clock setup

2011-04-11 Thread Tomi Valkeinen
On Fri, 2011-04-08 at 10:50 -0600, Paul Walmsley wrote: Hi Tomi, On Mon, 4 Apr 2011, Tomi Valkeinen wrote: Not directly related, but something I've been wondering about is how to abstract the DSI/HDMI PLLs in DSS. What do you think, would it be possible/worth it to create struct clks

Re: OMAP4 DSS clock setup

2011-04-11 Thread Paul Walmsley
Hi On Mon, 11 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-08 at 10:28 -0600, Paul Walmsley wrote: On Fri, 8 Apr 2011, Tomi Valkeinen wrote: Also, I hope you and the other DSS hackers can finish the PM runtime conversion of the DSS driver soon. Ideally before any new DSS

Re: OMAP4 DSS clock setup

2011-04-11 Thread Paul Walmsley
Hi On Mon, 11 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-08 at 08:55 -0600, Paul Walmsley wrote: On Fri, 8 Apr 2011, Tomi Valkeinen wrote: and not the clock used for the pixel clock? If so, I'm fine with having fck to be what it is currently, but then we need a new name for the

Re: OMAP4 DSS clock setup

2011-04-11 Thread Cousson, Benoit
On 4/11/2011 6:05 PM, Paul Walmsley wrote: Hi On Mon, 11 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-08 at 10:28 -0600, Paul Walmsley wrote: On Fri, 8 Apr 2011, Tomi Valkeinen wrote: Also, I hope you and the other DSS hackers can finish the PM runtime conversion of the DSS driver soon.

Re: OMAP4 DSS clock setup

2011-04-11 Thread Cousson, Benoit
On 4/11/2011 6:05 PM, Paul Walmsley wrote: Hi On Mon, 11 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-08 at 10:28 -0600, Paul Walmsley wrote: On Fri, 8 Apr 2011, Tomi Valkeinen wrote: Also, I hope you and the other DSS hackers can finish the PM runtime conversion of the DSS driver soon.

Re: OMAP4 DSS clock setup

2011-04-08 Thread Cousson, Benoit
Hi Paul, On 4/7/2011 9:27 PM, Paul Walmsley wrote: Hello Tomi, Benoît, On Mon, 4 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that changing the clock aliases is the way to go for right now. The clock

Re: OMAP4 DSS clock setup

2011-04-08 Thread Paul Walmsley
Hi On Fri, 8 Apr 2011, Tomi Valkeinen wrote: On Thu, 2011-04-07 at 13:27 -0600, Paul Walmsley wrote: On Mon, 4 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that changing the clock aliases

Re: OMAP4 DSS clock setup

2011-04-08 Thread Cousson, Benoit
Hi Tomi, On 4/8/2011 7:51 AM, Valkeinen, Tomi wrote: Hi Paul, On Thu, 2011-04-07 at 13:27 -0600, Paul Walmsley wrote: Hello Tomi, Benoît, On Mon, 4 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that

Re: OMAP4 DSS clock setup

2011-04-08 Thread Paul Walmsley
Hi Tomi, On Fri, 8 Apr 2011, Tomi Valkeinen wrote: Also, I hope you and the other DSS hackers can finish the PM runtime conversion of the DSS driver soon. Ideally before any new DSS features are added. We really need to be able to separate the OMAP integration details from the drivers,

Re: OMAP4 DSS clock setup

2011-04-08 Thread Tomi Valkeinen
On Fri, 2011-04-08 at 17:36 +0200, Cousson, Benoit wrote: Hi Tomi, On 4/8/2011 7:51 AM, Valkeinen, Tomi wrote: - If the modules are handled separately, how should the dependencies be handled? For example, dss_core's reset will reset all the other modules also, and most of the submodules

Re: OMAP4 DSS clock setup

2011-04-08 Thread Paul Walmsley
Hi Tomi, On Mon, 4 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Of course, at some point soon, those clock aliases are going to go away. But hopefully you all will have converted the driver over to PM runtime at that point. Once that

Re: OMAP4 DSS clock setup

2011-04-07 Thread Paul Walmsley
Hello Tomi, Benoît, On Mon, 4 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that changing the clock aliases is the way to go for right now. The clock aliases are not hardware data; they just control

Re: OMAP4 DSS clock setup

2011-04-07 Thread Tomi Valkeinen
Hi Paul, On Thu, 2011-04-07 at 13:27 -0600, Paul Walmsley wrote: Hello Tomi, Benoît, On Mon, 4 Apr 2011, Tomi Valkeinen wrote: On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that changing the clock aliases is the way to go

Re: OMAP4 DSS clock setup

2011-04-06 Thread Tomi Valkeinen
Paul, Benoit, On Mon, 2011-04-04 at 09:53 +0300, Tomi Valkeinen wrote: Hi Paul, Benoit, On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that changing the clock aliases is the way to go for right now. The clock aliases are not hardware

Re: OMAP4 DSS clock setup

2011-04-04 Thread Tomi Valkeinen
Hi Paul, Benoit, On Fri, 2011-04-01 at 20:12 -0600, Paul Walmsley wrote: Based on the E-mail thread so far, I'd say that changing the clock aliases is the way to go for right now. The clock aliases are not hardware data; they just control how the clock hardware is mapped to the drivers.

Re: OMAP4 DSS clock setup

2011-04-01 Thread Paul Walmsley
Hi Tomi, Benoît, et al, On Wed, 30 Mar 2011, Tomi Valkeinen wrote: Currently we have these aliases for OMAP4: dss_clk - dss_dss_clk fck - dss_fck ick - dummy_ck If that would be changed to: fck - dss_dss_clk ick - dss_fck The driver would work the same way for all OMAPs. This looks

Re: OMAP4 DSS clock setup

2011-03-31 Thread Archit Taneja
On Wednesday 30 March 2011 06:51 PM, Cousson, Benoit wrote: On 3/30/2011 2:58 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 14:12 +0200, Cousson, Benoit wrote: On 3/30/2011 1:03 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 11:32 +0200, Cousson, Benoit wrote: Hi Tomi, On 3/30/2011

Re: OMAP4 DSS clock setup

2011-03-31 Thread Tomi Valkeinen
On Wed, 2011-03-30 at 15:21 +0200, Cousson, Benoit wrote: On 3/30/2011 2:58 PM, Valkeinen, Tomi wrote: Anyway. To get things working for rc2 (DSS currently crashes due to not enabling dss_clk) we need to either: 1) Change the clock aliases as above Changing the clock alias for my point

Re: OMAP4 DSS clock setup

2011-03-31 Thread Cousson, Benoit
Hi Archit, On 3/31/2011 8:42 AM, Taneja, Archit wrote: On Wednesday 30 March 2011 06:51 PM, Cousson, Benoit wrote: On 3/30/2011 2:58 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 14:12 +0200, Cousson, Benoit wrote: On 3/30/2011 1:03 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 11:32

OMAP4 DSS clock setup

2011-03-30 Thread Tomi Valkeinen
Hi Benoit, Paul, I've been discussing with Sumit and Archit to understand how the DSS clocks are set up on OMAP4. I think I now have some idea how things work, but I'm still at loss why things are the way they are. So, if I look at OMAP4 TRM, Figure 10-4 DSS Clock Tree, there are two clocks in

Re: OMAP4 DSS clock setup

2011-03-30 Thread Cousson, Benoit
Hi Tomi, On 3/30/2011 8:48 AM, Valkeinen, Tomi wrote: Hi Benoit, Paul, I've been discussing with Sumit and Archit to understand how the DSS clocks are set up on OMAP4. I think I now have some idea how things work, but I'm still at loss why things are the way they are. So, if I look at OMAP4

Re: OMAP4 DSS clock setup

2011-03-30 Thread Tomi Valkeinen
On Wed, 2011-03-30 at 11:32 +0200, Cousson, Benoit wrote: Hi Tomi, On 3/30/2011 8:48 AM, Valkeinen, Tomi wrote: Hi Benoit, Paul, I've been discussing with Sumit and Archit to understand how the DSS clocks are set up on OMAP4. I think I now have some idea how things work, but I'm

Re: OMAP4 DSS clock setup

2011-03-30 Thread Cousson, Benoit
On 3/30/2011 1:03 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 11:32 +0200, Cousson, Benoit wrote: Hi Tomi, On 3/30/2011 8:48 AM, Valkeinen, Tomi wrote: Hi Benoit, Paul, I've been discussing with Sumit and Archit to understand how the DSS clocks are set up on OMAP4. I think I now have

Re: OMAP4 DSS clock setup

2011-03-30 Thread Tomi Valkeinen
On Wed, 2011-03-30 at 14:12 +0200, Cousson, Benoit wrote: On 3/30/2011 1:03 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 11:32 +0200, Cousson, Benoit wrote: Hi Tomi, On 3/30/2011 8:48 AM, Valkeinen, Tomi wrote: Hi Benoit, Paul, I've been discussing with Sumit and Archit to

Re: OMAP4 DSS clock setup

2011-03-30 Thread Cousson, Benoit
On 3/30/2011 2:58 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 14:12 +0200, Cousson, Benoit wrote: On 3/30/2011 1:03 PM, Valkeinen, Tomi wrote: On Wed, 2011-03-30 at 11:32 +0200, Cousson, Benoit wrote: Hi Tomi, On 3/30/2011 8:48 AM, Valkeinen, Tomi wrote: Hi Benoit, Paul, I've been