Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-10-13 Thread Lucas Stach
Am Freitag, den 25.09.2015, 20:44 + schrieb Woodruff, Richard: > > From: Menon, Nishanth > > Sent: Friday, September 25, 2015 9:44 AM > > > > If I688 is not needed on am335x, then it seems there are still some > > > mysteries remaining with this erratum to unravel. Something like > > >

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-10-13 Thread Russell King - ARM Linux
On Tue, Oct 13, 2015 at 12:10:45PM +, Woodruff, Richard wrote: > > From: Lucas Stach [mailto:l.st...@pengutronix.de] > > Sent: Tuesday, October 13, 2015 5:01 AM > > > So please help me to get this straight: > > > > Errata I688 only affects OMAP4 which is consequently the only user of > >

RE: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-10-13 Thread Woodruff, Richard
> From: Lucas Stach [mailto:l.st...@pengutronix.de] > Sent: Tuesday, October 13, 2015 5:01 AM > So please help me to get this straight: > > Errata I688 only affects OMAP4 which is consequently the only user of > omap_interconnect_sync() in it's WFI enter sequence, which in turn is > the only

RE: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-10-13 Thread Woodruff, Richard
> From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] > Sent: Tuesday, October 13, 2015 7:24 AM > If you implement drivers using nothing but writel() and readl(), then your > performance _will_ suck, but that's entirely the driver's fault. Your above analysis seems correct. Perhaps

RE: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-29 Thread Woodruff, Richard
Hello Robert, > From: Robert Schwebel [mailto:r.schwe...@pengutronix.de] > Sent: Tuesday, September 29, 2015 12:50 PM > > -1- > > Barrier side effects of the patch may be beneficial for other reasons. But > AM335x should be immune from this particular issue. > > Is this a matter of fact, or

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-29 Thread Robert Schwebel
Hi Richard, On Fri, Sep 25, 2015 at 08:44:29PM +, Woodruff, Richard wrote: > > From: Menon, Nishanth > > Sent: Friday, September 25, 2015 9:44 AM > > > > If I688 is not needed on am335x, then it seems there are still some > > > mysteries remaining with this erratum to unravel. Something like

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-29 Thread Robert Schwebel
On Tue, Sep 29, 2015 at 06:06:36PM +, Woodruff, Richard wrote: > > From: Robert Schwebel [mailto:r.schwe...@pengutronix.de] > > Sent: Tuesday, September 29, 2015 12:50 PM > > > -1- > > > Barrier side effects of the patch may be beneficial for other reasons. > > > But > > AM335x should be

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-25 Thread Tony Lindgren
* Bastian Stender [150925 05:40]: > Hi, > > On 09/25/2015 02:08 PM, Russell King - ARM Linux wrote: > >On Fri, Sep 25, 2015 at 12:01:13PM +0200, Bastian Stender wrote: > >>Signed-off-by: Bastian Stender > >>--- > >> arch/arm/mach-omap2/omap4-common.c |

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-25 Thread Nishanth Menon
On 09/25/2015 09:35 AM, Tony Lindgren wrote: > * Bastian Stender [150925 05:40]: >> Hi, >> >> On 09/25/2015 02:08 PM, Russell King - ARM Linux wrote: >>> On Fri, Sep 25, 2015 at 12:01:13PM +0200, Bastian Stender wrote: Signed-off-by: Bastian Stender

RE: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-25 Thread Woodruff, Richard
> From: Menon, Nishanth > Sent: Friday, September 25, 2015 9:44 AM > > If I688 is not needed on am335x, then it seems there are still some > > mysteries remaining with this erratum to unravel. Something like > > difference in the L3 implementation. Maybe somebody from TI can > > investigate which

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-25 Thread Bastian Stender
Hi, On 09/25/2015 02:08 PM, Russell King - ARM Linux wrote: On Fri, Sep 25, 2015 at 12:01:13PM +0200, Bastian Stender wrote: Signed-off-by: Bastian Stender --- arch/arm/mach-omap2/omap4-common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH] ARM: OMAP2: erratum I688 handling disabled for AM335x

2015-09-25 Thread Russell King - ARM Linux
On Fri, Sep 25, 2015 at 12:01:13PM +0200, Bastian Stender wrote: > Signed-off-by: Bastian Stender > --- > arch/arm/mach-omap2/omap4-common.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap4-common.c >