Bug in omap2_nand_gpmc_retime? (was: Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied)

2010-04-28 Thread Mike Rapoport
Tony Lindgren wrote: * Mike Rapoport m...@compulab.co.il [100427 00:40]: Tony Lindgren wrote: * Mike Rapoport m...@compulab.co.il [100422 01:41]: Ghorai, Sukumar wrote: CM-T35, for instance can be assembled with different NAND flash chips. Besides, boards that use NAND as primary boot

Re: Bug in omap2_nand_gpmc_retime? (was: Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied)

2010-04-28 Thread Vimal Singh
On Wed, Apr 28, 2010 at 8:35 PM, Mike Rapoport m...@compulab.co.il wrote: Tony Lindgren wrote: * Mike Rapoport m...@compulab.co.il [100427 00:40]: Tony Lindgren wrote: * Mike Rapoport m...@compulab.co.il [100422 01:41]: Ghorai, Sukumar wrote: CM-T35, for instance can be assembled with

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-27 Thread Mike Rapoport
Tony Lindgren wrote: * Mike Rapoport m...@compulab.co.il [100422 01:41]: Ghorai, Sukumar wrote: CM-T35, for instance can be assembled with different NAND flash chips. Besides, boards that use NAND as primary boot device, we anyway depend on proper GPMC configuration in the bootloader chain.

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-27 Thread Tony Lindgren
* Mike Rapoport m...@compulab.co.il [100427 00:40]: Tony Lindgren wrote: * Mike Rapoport m...@compulab.co.il [100422 01:41]: Ghorai, Sukumar wrote: CM-T35, for instance can be assembled with different NAND flash chips. Besides, boards that use NAND as primary boot device, we anyway depend

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-26 Thread Tony Lindgren
* Mike Rapoport m...@compulab.co.il [100422 01:41]: Ghorai, Sukumar wrote: CM-T35, for instance can be assembled with different NAND flash chips. Besides, boards that use NAND as primary boot device, we anyway depend on proper GPMC configuration in the bootloader chain. Having ability to

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-26 Thread Vimal Singh
On Mon, Apr 26, 2010 at 11:44 PM, Tony Lindgren t...@atomide.com wrote: * Mike Rapoport m...@compulab.co.il [100422 01:41]: Ghorai, Sukumar wrote: CM-T35, for instance can be assembled with different NAND flash chips. Besides, boards that use NAND as primary boot device, we anyway depend on

RE: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-22 Thread Ghorai, Sukumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Mike Rapoport Sent: 2010-04-22 10:50 To: linux-omap@vger.kernel.org Cc: Tony Lindgren; Mike Rapoport Subject: Re: [PATCH] OMAP: fix gpmc nand setup when no timings

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-22 Thread Mike Rapoport
Ghorai, Sukumar wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Mike Rapoport Sent: 2010-04-22 10:50 To: linux-omap@vger.kernel.org Cc: Tony Lindgren; Mike Rapoport Subject: Re: [PATCH] OMAP: fix gpmc nand setup

RE: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-22 Thread Ghorai, Sukumar
-Original Message- From: Mike Rapoport [mailto:m...@compulab.co.il] Sent: 2010-04-22 12:29 To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org; Tony Lindgren Subject: Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied Ghorai, Sukumar wrote: -Original Message

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-22 Thread Mike Rapoport
Ghorai, Sukumar wrote: -Original Message- From: Mike Rapoport [mailto:m...@compulab.co.il] Sent: 2010-04-22 12:29 To: Ghorai, Sukumar Cc: linux-omap@vger.kernel.org; Tony Lindgren Subject: Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied Ghorai, Sukumar wrote

Re: [PATCH] OMAP: fix gpmc nand setup when no timings supplied

2010-04-21 Thread Mike Rapoport
Any comments on this? Mike Rapoport wrote: The gpmc nand infrastructure crashes when there no timing structure supplied in the omap_nand_platform_data. Adding check for gpmc_nand_data-gpmc_t pointer validity resolves the crash and allows to continue nand initialization without modifying gpmc