RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-17 Thread Rajendra Nayak
: "Högander" Jouni [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 09, 2008 2:05 PM > To: ext Rajendra Nayak > Cc: linux-omap@vger.kernel.org > Subject: Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix. > > Hi, Rajendra > > I think we have now all the pieces her

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-11 Thread Woodruff, Richard
> >> When OFF/RET mode is selected IO pad is enabled for the port > wakeup. > >> > >> I have seen this in CDP reference code. Is there some specific > reason > >> why this is enabled dynamically in code? > > > > Not that I am aware. > > > > Do you think there is a need to toggle it? Today only th

Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-11 Thread Högander Jouni
"ext Woodruff, Richard" <[EMAIL PROTECTED]> writes: >> > The current check will: On activity raise a cpuidle bus master >> > activity failure for some number of seconds. This allows normal >> > typing for extended periods. It does this by marking UART function >> > IRQs with a time stamp and it

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-10 Thread Woodruff, Richard
> > The current check will: On activity raise a cpuidle bus master > > activity failure for some number of seconds. This allows normal > > typing for extended periods. It does this by marking UART function > > IRQs with a time stamp and it checks internal state to make sure > > RX/TX engine is no

Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-10 Thread Högander Jouni
"ext Woodruff, Richard" <[EMAIL PROTECTED]> writes: > Hi, > >> > static void serial8250_stop_tx(struct uart_port *port) >> > @@ -1268,6 +1276,15 @@ static void serial8250_start_tx(struct u >> > up->acr &= ~UART_ACR_TXDIS; >> > serial_icr_write(up, UART_ACR, up->acr

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-10 Thread Woodruff, Richard
Hi, > Impact of this change depends a lot on what is happening on the > system. HW triggered dma transfer comes to my mind first. In that case > mpu could be kept in OFF state while core is active. Changing bm > check this way would cause mpu to be kept in INACTIVE state. Any > analysis of the imp

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-10 Thread Woodruff, Richard
Hi, > > static void serial8250_stop_tx(struct uart_port *port) > > @@ -1268,6 +1276,15 @@ static void serial8250_start_tx(struct u > > up->acr &= ~UART_ACR_TXDIS; > > serial_icr_write(up, UART_ACR, up->acr); > > } > > +#ifdef CONFIG_OMAP3_PM > > + { >

Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-09 Thread Högander Jouni
Hi, "ext Woodruff, Richard" <[EMAIL PROTECTED]> writes: > Hi, > >> > I think we have now all the pieces here to get stable cpuidle + >> > pm_idle + suspend + off mode with minimal configuration on SDP >> > board. Could you Rajendra now gather these together and prepare new >> > patch set in sensi

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-09 Thread Woodruff, Richard
Hi, > > I think we have now all the pieces here to get stable cpuidle + > > pm_idle + suspend + off mode with minimal configuration on SDP > > board. Could you Rajendra now gather these together and prepare new > > patch set in sensible format? > > Yes, I will do that. Will re-send the complete pa

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-09 Thread Rajendra Nayak
> -Original Message- > From: "Högander" Jouni [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 09, 2008 2:05 PM > To: ext Rajendra Nayak > Cc: linux-omap@vger.kernel.org > Subject: Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix. > > Hi, Rajendra &

Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-09 Thread Högander Jouni
CTED]> writes: >> -Original Message- >> From: "Högander" Jouni [mailto:[EMAIL PROTECTED] >> Sent: Wednesday, July 09, 2008 12:29 PM >> To: ext Rajendra Nayak >> Cc: linux-omap@vger.kernel.org >> Subject: Re: [PATCH] OMAP3: CPUIDLE & PM: ch

Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-09 Thread Högander Jouni
"ext Rajendra Nayak" <[EMAIL PROTECTED]> writes: >> -Original Message- >> From: "Högander" Jouni [mailto:[EMAIL PROTECTED] >> Sent: Wednesday, July 09, 2008 12:29 PM >> To: ext Rajendra Nayak >> Cc: linux-omap@vger.kernel.org &

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-09 Thread Rajendra Nayak
> -Original Message- > From: "Högander" Jouni [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 09, 2008 12:29 PM > To: ext Rajendra Nayak > Cc: linux-omap@vger.kernel.org > Subject: Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix. > > "ext

Re: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-08 Thread Högander Jouni
"ext Rajendra Nayak" <[EMAIL PROTECTED]> writes: > >> -Original Message- >> From: Jouni Hogander [mailto:[EMAIL PROTECTED] >> Sent: Wednesday, July 09, 2008 12:00 PM >> To: linux-omap@vger.kernel.org; [EMAIL PROTECTED] >> Subject: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix. >> >> This p

RE: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix.

2008-07-08 Thread Rajendra Nayak
> -Original Message- > From: Jouni Hogander [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 09, 2008 12:00 PM > To: linux-omap@vger.kernel.org; [EMAIL PROTECTED] > Subject: [PATCH] OMAP3: CPUIDLE & PM: check_bm fix. > > This patch fixes problems with uart usage. omap3_enter_idle_bm wa