RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-15 Thread Shilimkar, Santosh
snip -Original Message- From: Varadarajan, Charu Latha Sent: Thursday, October 15, 2009 10:59 AM To: Shilimkar, Santosh; linux-omap@vger.kernel.org Cc: Syed, Rafiuddin Subject: RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

Re: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-15 Thread Peter Ujfalusi
On Thursday 15 October 2009 09:10:54 ext Shilimkar, Santosh wrote: - writew(buf, base + OMAP_MCBSP_REG_DXR1); + OMAP_MCBSP_WRITE(base, DXR, buf); Why do you need this? Is writew()/readw() not doing 16 bit operations ? The intension is to use 32 bit access

RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-15 Thread Shilimkar, Santosh
Charu, -Original Message- From: Peter Ujfalusi [mailto:peter.ujfal...@nokia.com] Sent: Thursday, October 15, 2009 12:56 PM To: Shilimkar, Santosh Cc: Varadarajan, Charu Latha; linux-omap@vger.kernel.org; Syed, Rafiuddin Subject: Re: [PATCH] OMAP3: Fix McBSP poll read and write

Re: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-14 Thread vimal singh
On Wed, Oct 14, 2009 at 3:00 PM, ch...@ti.com wrote: omap_mcbsp_pollwrite and omap_mcbsp_pollread functions access McBSP registers as 16-bit registers. The McBSP registers (DRR_REG and DXR_REG) are limited to 32-bit data accesses (L4 Interconnect). 16-bit and 8-bit is not allowed and can

RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-14 Thread Shilimkar, Santosh
Charu, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Varadarajan, Charu Latha Sent: Wednesday, October 14, 2009 3:00 PM To: linux-omap@vger.kernel.org Cc: Varadarajan, Charu Latha; Syed, Rafiuddin Subject: [PATCH]

RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-14 Thread G, Manjunath Kondaiah
McBSP poll read and write for 32bit reg access        base = mcbsp-io_base;        /* if frame sync error - clear the error */ -       if (readw(base + OMAP_MCBSP_REG_SPCR1) RSYNC_ERR) { +       if (OMAP_MCBSP_READ(base, SPCR1) RSYNC_ERR) {                /* clear error

RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-14 Thread Varadarajan, Charu Latha
-Original Message- From: G, Manjunath Kondaiah Sent: Wednesday, October 14, 2009 4:01 PM To: 'vimal singh'; Varadarajan, Charu Latha Cc: linux-omap@vger.kernel.org; Syed, Rafiuddin Subject: RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access -Original

RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-14 Thread Varadarajan, Charu Latha
__ Subject: RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access Charu, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Varadarajan, Charu Latha Sent

RE: [PATCH] OMAP3: Fix McBSP poll read and write for 32bit reg access

2009-10-14 Thread Varadarajan, Charu Latha
McBSP poll read and write for 32bit reg access On Wed, Oct 14, 2009 at 3:00 PM, ch...@ti.com wrote: omap_mcbsp_pollwrite and omap_mcbsp_pollread functions access McBSP registers as 16-bit registers. The McBSP registers (DRR_REG and DXR_REG) are limited to 32-bit data accesses