Re: [PATCH 02/12] ARM: OMAP2+: PM: introduce power domains functional states

2013-01-29 Thread Paul Walmsley
Hi (redacted some context) On Wed, 12 Dec 2012, Jean Pihet wrote: On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley p...@pwsan.com wrote: +/** + * _match_pwrst: determine the closest supported power state + * @pwrsts: list of allowed states, defined as a bitmask + * @pwrst: initial state

Re: [PATCH 02/12] ARM: OMAP2+: PM: introduce power domains functional states

2013-01-04 Thread Tero Kristo
Hi Paul / Jean, On Wed, 2012-12-12 at 11:33 +0100, Jean Pihet wrote: clip +/** + * _match_pwrst: determine the closest supported power state + * @pwrsts: list of allowed states, defined as a bitmask + * @pwrst: initial state to be used as a starting point + * @min: minimum (i.e.

RE: [PATCH 02/12] ARM: OMAP2+: PM: introduce power domains functional states

2012-12-25 Thread Bedia, Vaibhav
Hi Paul, A minor comment below. On Sun, Dec 09, 2012 at 23:23:01, Paul Walmsley wrote: [...] + + pr_debug(powerdomain: convert pwrst (%0x,%0x) to fpwrst %0x\n, + pwrst, logic, *fpwrst); + This function alone does not print the powerdomain name. Can you add that in the final

Re: [PATCH 02/12] ARM: OMAP2+: PM: introduce power domains functional states

2012-12-12 Thread Vaibhav Hiremath
On 12/9/2012 11:23 PM, Paul Walmsley wrote: From: Jean Pihet jean.pi...@newoldbits.com Introduce the functional states for power domains, which include the power states and the logic states. This patch provides the API functions to set and read the power domains functional state and

Re: [PATCH 02/12] ARM: OMAP2+: PM: introduce power domains functional states

2012-12-12 Thread Jean Pihet
Hi Paul, -resending in plain text only, sorry about that- On Sun, Dec 9, 2012 at 6:53 PM, Paul Walmsley p...@pwsan.com wrote: From: Jean Pihet jean.pi...@newoldbits.com Introduce the functional states for power domains, which include the power states and the logic states. This patch