RE: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-10-03 Thread Philippe De Swert
Hi all, On 26/09/2012, Philippe De Swert philippe.desw...@jollamobile.com wrote: Hi, On Tue, Sep 25, 2012 at 2:39 PM, Philippe De Swert Then maybe it's best to just remove the ifdefs and always provide generic_interrupt() ? Anyone against it ?

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-10-03 Thread Praveena Nadahally
On Wed, Oct 3, 2012 at 7:15 PM, Philippe De Swert philippe.desw...@jollamobile.com wrote: So any comments on the approach here (see patch kept below)? Or should I immediately send it as a new patch to get the comments? I sent it in this thread as it also solves the issue I have. Patch is

RE: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-26 Thread Philippe De Swert
Hi, On Tue, Sep 25, 2012 at 2:39 PM, Philippe De Swert Then maybe it's best to just remove the ifdefs and always provide generic_interrupt() ? Anyone against it ? Providing generic_interrupt seems fine. Well it seems there are only two drivers that

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-25 Thread Felipe Balbi
Hi, On Mon, Sep 24, 2012 at 09:09:14AM -0700, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [120924 06:08]: Hi, On Mon, Sep 24, 2012 at 03:54:22PM +0300, Philippe De Swert wrote: Hi, On 24/09/2012, Felipe Balbi ba...@ti.com wrote: SoB's mail doesn't From mail. Well

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-25 Thread Philippe De Swert
Hi, On 25/09/2012, Felipe Balbi ba...@ti.com wrote: Not a mention of CONFIG_SOC_OMAP2430 and CONFIG_SOC_OMAP3430 did not get set (while it is not a 3430 but a 3630 I am using). Maybe CONFIG_ARCH_OMAP3 would have been a better choice then? that's quite f**ked up. Tony, why doesn't

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-25 Thread Praveena Nadahally
On Tue, Sep 25, 2012 at 2:39 PM, Philippe De Swert philippedesw...@gmail.com wrote: Hi, On 25/09/2012, Felipe Balbi ba...@ti.com wrote: Then maybe it's best to just remove the ifdefs and always provide generic_interrupt() ? Anyone against it ? Providing generic_interrupt seems fine. Well

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Felipe Balbi
Hi, On Mon, Sep 24, 2012 at 02:53:24PM +0300, philippedesw...@gmail.com wrote: From: Philippe De Swert philippe.desw...@jollamobile.com Unless generic_interrupt is defined the irq setup in musb_init_controller fails for the omap2430 driver since that one does not set it's own interrupt

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Felipe Balbi
On Mon, Sep 24, 2012 at 03:15:39PM +0300, Felipe Balbi wrote: Hi, On Mon, Sep 24, 2012 at 02:53:24PM +0300, philippedesw...@gmail.com wrote: From: Philippe De Swert philippe.desw...@jollamobile.com Unless generic_interrupt is defined the irq setup in musb_init_controller fails for the

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Philippe De Swert
Hi, On 24/09/2012, Felipe Balbi ba...@ti.com wrote: SoB's mail doesn't From mail. Well still in the progress of migrating of my personal to work laptop. Since the patch does not seem correct the replacement will have matching addresses.

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Felipe Balbi
Hi, On Mon, Sep 24, 2012 at 03:54:22PM +0300, Philippe De Swert wrote: Hi, On 24/09/2012, Felipe Balbi ba...@ti.com wrote: SoB's mail doesn't From mail. Well still in the progress of migrating of my personal to work laptop. Since the patch does not seem correct the replacement will have

Re: [PATCH 1/1] usb: Include generic_interrupt for OMAP2_PLUS

2012-09-24 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [120924 06:08]: Hi, On Mon, Sep 24, 2012 at 03:54:22PM +0300, Philippe De Swert wrote: Hi, On 24/09/2012, Felipe Balbi ba...@ti.com wrote: SoB's mail doesn't From mail. Well still in the progress of migrating of my personal to work laptop. Since the