Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-07 Thread Felipe Balbi
On Tue, Dec 07, 2010 at 07:25:12PM +0530, Gupta, Ajay Kumar wrote: Hi, >> Is AM35x that different ? Can't you just write to MUSB_INTRRX >> MUSB_INTRTX and MUSB_INTRUSB ?? >Writing to MUSB_INTRRX/TX/USB wouldn't help. We have to clear interrupt >Bit in control register INTR_LVL_CLR. I see, thank

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-07 Thread Gupta, Ajay Kumar
Hi, > >> Is AM35x that different ? Can't you just write to MUSB_INTRRX > >> MUSB_INTRTX and MUSB_INTRUSB ?? > >Writing to MUSB_INTRRX/TX/USB wouldn't help. We have to clear interrupt > >Bit in control register INTR_LVL_CLR. > > I see, thanks for the info :-) Felipe, I have recreated this patch (

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-06 Thread Felipe Balbi
On Mon, Dec 06, 2010 at 05:24:53PM +0530, Gupta, Ajay Kumar wrote: On Fri, Dec 03, 2010 at 07:08:53PM +0530, Gupta, Ajay Kumar wrote: >> >We already have generic APIs so I think we can pass function pointers to >> >musb driver via "struct omap_musb_board_data", >> > >> > struct omap_musb_board_da

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-06 Thread Gupta, Ajay Kumar
> On Fri, Dec 03, 2010 at 07:08:53PM +0530, Gupta, Ajay Kumar wrote: > >> >We already have generic APIs so I think we can pass function pointers > to > >> >musb driver via "struct omap_musb_board_data", > >> > > >> > struct omap_musb_board_data { > >> >+ void(*phy_on) (void) > >> >+ void(*p

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-06 Thread Felipe Balbi
On Fri, Dec 03, 2010 at 07:08:53PM +0530, Gupta, Ajay Kumar wrote: >We already have generic APIs so I think we can pass function pointers to >musb driver via "struct omap_musb_board_data", > > struct omap_musb_board_data { >+ void(*phy_on) (void) >+ void(*phy_off) (void) >+ void (*

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-03 Thread Gupta, Ajay Kumar
> >We already have generic APIs so I think we can pass function pointers to > >musb driver via "struct omap_musb_board_data", > > > > struct omap_musb_board_data { > >+void(*phy_on) (void) > >+void(*phy_off) (void) > >+void (*intr_clr) (void) > > } > > > >Reset part can be done

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-03 Thread Felipe Balbi
On Thu, Dec 02, 2010 at 04:13:50PM +0530, Gupta, Ajay Kumar wrote: >> why don't you add a proper otg_transceiver driver for am35x ? >> Is it like omap4's internal phy ? A separate block ? > >AM35x PHY is built inside the ip and we need to configure it through >PHY control register. > >Additionall

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-02 Thread Gupta, Ajay Kumar
> >> why don't you add a proper otg_transceiver driver for am35x ? > >> Is it like omap4's internal phy ? A separate block ? > > > >AM35x PHY is built inside the ip and we need to configure it through > >PHY control register. > > > >Additionally we also need to access IPSS reset and Intr clear regi

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-02 Thread Felipe Balbi
On Thu, Dec 02, 2010 at 10:22:11AM +0530, Gupta, Ajay Kumar wrote: > We would need control register apis for accessing USB PHY control > , IPSS reset and interrupt clear register. This would require to > add three different function pointer and that would mostly be > custom to AM35x. Will that be

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-01 Thread Gupta, Ajay Kumar
> > We would need control register apis for accessing USB PHY control > > , IPSS reset and interrupt clear register. This would require to > > add three different function pointer and that would mostly be > > custom to AM35x. Will that be acceptable from musb perspective ? > > why don't you add a

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-01 Thread Felipe Balbi
On Wed, 2010-12-01 at 17:38 +0530, Gupta, Ajay Kumar wrote: > > >> Tony ? Do you ack the usage of that header ? > > > > > >NAK. Drivers should not mess with the control registers directly. > > > > > >Instead, the following should be done in the platform init code: > > > > > >$ grep -r omap_ctrl_rea

RE: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-01 Thread Gupta, Ajay Kumar
> >> Tony ? Do you ack the usage of that header ? > > > >NAK. Drivers should not mess with the control registers directly. > > > >Instead, the following should be done in the platform init code: > > > >$ grep -r omap_ctrl_read drivers/usb > >drivers/usb/musb/am35x.c: devconf2 = > omap_ctrl_re

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-12-01 Thread Felipe Balbi
On Tue, Nov 30, 2010 at 10:30:10AM -0800, Tony Lindgren wrote: * Felipe Balbi [101122 02:12]: Hi, On Mon, Nov 22, 2010 at 02:22:40PM +0530, Ajay Kumar Gupta wrote: >Fixes compilation error as control.h APIs are not available to >drivers/usb/musb/am35x.c file. Earlier it was getting included >f

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-11-30 Thread Tony Lindgren
* Felipe Balbi [101122 02:12]: > Hi, > > On Mon, Nov 22, 2010 at 02:22:40PM +0530, Ajay Kumar Gupta wrote: > >Fixes compilation error as control.h APIs are not available to > >drivers/usb/musb/am35x.c file. Earlier it was getting included > >from but now moved to new location by another > >pacth

Re: [PATCH 1/2] AM35x: musb: fix compilation error

2010-11-22 Thread Felipe Balbi
Hi, On Mon, Nov 22, 2010 at 02:22:40PM +0530, Ajay Kumar Gupta wrote: Fixes compilation error as control.h APIs are not available to drivers/usb/musb/am35x.c file. Earlier it was getting included from but now moved to new location by another pacth. Signed-off-by: Ajay Kumar Gupta Tony ? Do