RE: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence

2011-10-07 Thread Vishwanath Sripathy
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Friday, October 07, 2011 1:50 PM > To: Vishwanath BS > Cc: linux-omap@vger.kernel.org; khil...@ti.com; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH 1/4] ARM: OMAP3 PM: Fix I

Re: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence

2011-10-07 Thread Paul Walmsley
Hi a few comments: On Tue, 4 Oct 2011, Vishwanath BS wrote: > As per OMAP3630 TRM Section 3.5.7.2.2, the right sequence for enabling IO > Daisy > chain is "The I/O wake-up scheme is enabled by triggering the I/O daisy chain > control (Wu clock) by programming a dedicated register > (PRCM.PM_WKE

RE: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence

2011-10-04 Thread Vishwanath Sripathy
> -Original Message- > From: Kevin Hilman [mailto:khil...@ti.com] > Sent: Wednesday, October 05, 2011 2:18 AM > To: Vishwanath BS > Cc: linux-omap@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; moh...@ti.com > Subject: Re: [PATCH 1/4] ARM: OMAP3 PM: Fix I

Re: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence

2011-10-04 Thread Kevin Hilman
Hi Vishwa, Vishwanath BS writes: > As per OMAP3630 TRM Section 3.5.7.2.2, the right sequence for enabling IO > Daisy > chain is "The I/O wake-up scheme is enabled by triggering the I/O daisy chain > control (Wu clock) by programming a dedicated register > (PRCM.PM_WKEN_WKUP[16] EN_IO_CHAIN) in

Re: [PATCH 1/4] ARM: OMAP3 PM: Fix IO Daisychain sequence

2011-10-04 Thread Tony Lindgren
* Vishwanath BS [111004 10:25]: > @@ -105,7 +105,7 @@ static void omap3_enable_io_chain(void) > /* Do a readback to assure write has been done */ > omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN); > > - while (!(omap2_prm_read_mod_reg(WKUP_MOD, PM_WKEN) & > +