felipe.ba...@nokia.com wrote: > From: Felipe Balbi <felipe.ba...@nokia.com> > > Errata ID i445 says we SOFTRESET doesn't work properly > on omap3630, so let's avoid issuing that here. >
Not really - all it says is that a ULPI reset is not propagated to the PHY when you softreset the controller. The controller softreset itself is quite functional. Also, this is applicable to 3430 as well and is not 3630 specific. So I'd NAK this patch. > Signed-off-by: Felipe Balbi <felipe.ba...@nokia.com> > --- > arch/arm/mach-omap2/usb-musb.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c > index de3e768..97dae0d 100644 > --- a/arch/arm/mach-omap2/usb-musb.c > +++ b/arch/arm/mach-omap2/usb-musb.c > @@ -54,6 +54,10 @@ void __init usb_musb_pm_init(void) > if (!cpu_is_omap34xx()) > return; > > + /* Errata ID i445 fix : Do not use SOFTRESET with OMAP3630 */ > + if (cpu_is_omap3630()) > + return; > + > otg_base = ioremap(OMAP34XX_HSUSB_OTG_BASE, SZ_4K); > if (WARN_ON(!otg_base)) > return; -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
