RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hi, It would not scale very well - we already have multi-omap builds that select support for multiple boards. If the AM35x boards are part of such builds, then mutually exclusive config options won't work - already n8x0 MUSB is exclusive with 243x/omap3. If it is possible to detect the

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hi, AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- Patch created against linus'tree + all musb patches in Greg's queue Changes from v1: - removed unnecessary parens.

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hello. Gupta, Ajay Kumar wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- Patch created against linus'tree + all musb patches in Greg's queue Changes from v1: -

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Gupta, Ajay Kumar wrote: Fixes/workaround based on CONFIG_MACH_OMAP3517EVM will be good only for OMAP3517EVM and would not scale well to other boards based on AM35x. (As commented earlier by Sergei) I just got to know of another board LIZARD based on AM35x so we really need to find a

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hi, Gupta, Ajay Kumar wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com [...] +#if !defined(CONFIG_MACH_OMAP3517EVM) Fixes/workaround based on

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hi, Fixes/workaround based on CONFIG_MACH_OMAP3517EVM will be good only for OMAP3517EVM and would not scale well to other boards based on AM35x. (As commented earlier by Sergei) I just got to know of another board LIZARD based on AM35x so we really need to find a solution for this.

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

On Thu, May 20, 2010 at 11:41:14AM +0200, ext Gadiyar, Anand wrote: It would not scale very well - we already have multi-omap builds that select support for multiple boards. If the AM35x boards are part of such builds, then mutually exclusive config options won't work - already n8x0 MUSB is

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

On Thu, May 20, 2010 at 12:06:30PM +0200, Balbi Felipe (Nokia-D/Helsinki) wrote: arm-based only) boards and be sure it would work. We would just need to put something similar down for dma engines. and of course, the same platform-code could instantiate a dma engine platform_device but that's

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hello. Ajay Kumar Gupta wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. But don't we need to override musb_readb() and musb_readw() then? Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com WBR, Sergei -- To

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Hi AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. But don't we need to override musb_readb() and musb_readw() then? Yes, Correct. I do have another patch on that which I will cleanup and submit later. Anyways with currebt three

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

Ajay Kumar Gupta ajay.gu...@ti.com wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com ---  drivers/usb/musb/am3517.c    |   30 ++