RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-10 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Thu, Feb 10, 2011 at 08:19:19PM +0530, Santosh Shilimkar wrote: > > This patch will need below update so that the smp_scu.h > > header can be included from ass

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-10 Thread Russell King - ARM Linux
On Thu, Feb 10, 2011 at 08:19:19PM +0530, Santosh Shilimkar wrote: > This patch will need below update so that the smp_scu.h > header can be included from assembly files. Will you > fold this into your patch or you want me to > send below as separate patch ? Folded. -- To unsubscribe from this lis

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-10 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > [] > > > 8<-- > > > Subject: [PATCH] ARM: smp: add function to set WFI low-power > mode > > > for SMP CPUs > > > > > > A

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-07 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Mon, Feb 07, 2011 at 03:51:04PM +0530, Santosh Shilimkar wrote: > > > > > +int scu_power_mode(void __iomem *scu_base, unsigned int > mode) > > >

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-07 Thread Russell King - ARM Linux
On Mon, Feb 07, 2011 at 03:51:04PM +0530, Santosh Shilimkar wrote: > > > > +int scu_power_mode(void __iomem *scu_base, unsigned int mode) > > > > +{ > > > > + unsigned int val; > > > > + int cpu = smp_processor_id(); > > > > + int shift; > > > shift is unused with this version now

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-07 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > [] > > > +int scu_power_mode(void __iomem *scu_base, unsigned int mode) > > > +{ > > > + unsigned int val; > > > + int cpu = smp_processor_

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-07 Thread Russell King - ARM Linux
om; linus.ml.wall...@gmail.com; linux- > > o...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > ccr...@android.com > > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > > file > > > [.] > > > 8<-- > > Subject: [PAT

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-07 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > [.] > 8<-- > Subject: [PATCH] ARM: smp: add function to set WFI low-power mode > for SMP CPUs > > Add a function to set the SCU low-power mode for SMP CPU

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-04 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Fri, Feb 04, 2011 at 04:16:07PM +0530, Santosh Shilimkar wrote: > > > -Original Message- > > > From: Russell King - ARM Linux [mailto:li...@arm.li

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-04 Thread Russell King - ARM Linux
om; linus.ml.wall...@gmail.com; linux- > > o...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > ccr...@android.com > > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > > file > > > > On Tue, Jan 25, 2011 at 11:53:35PM +0530, Santosh Sh

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-04 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Tue, Jan 25, 2011 at 11:53:35PM +0530, Santosh Shilimkar wrote: > > After fixing the 3rd version for base address break, I was able to > > use this patch and

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-02-04 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 11:53:35PM +0530, Santosh Shilimkar wrote: > After fixing the 3rd version for base address break, I was able to > use this patch and test it. Seems to work. SMC related stuff can > be ignored because OMAP4 ES1.0 doesn't have functional PM hardware > support. I think I'd pre

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Tue, Jan 25, 2011 at 01:04:22PM +, Russell King - ARM Linux > wrote: > > Actually, we can do this safely - byte stores are permitted to SCU > > registers

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Santosh Shilimkar
il.com; linux- > o...@vger.kernel.org > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Tue, Jan 25, 2011 at 06:06:27PM +0530, Santosh Shilimkar wrote: > > Ok. I missed some information my last email. > > The SCU power status programming is u

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 06:06:27PM +0530, Santosh Shilimkar wrote: > Ok. I missed some information my last email. > The SCU power status programming is used to take CPU in/out > of coherency as an alternative to SMP bit. We don't > have an access to SMP bit on OMAP4. ARM has already > confirmed SCU

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Santosh Shilimkar
il.com; linux- > o...@vger.kernel.org > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Tue, Jan 25, 2011 at 06:06:27PM +0530, Santosh Shilimkar wrote: > > Ok. I missed some information my last email. > > The SCU power status programming is u

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 01:04:22PM +, Russell King - ARM Linux wrote: > Actually, we can do this safely - byte stores are permitted to SCU > registers probably for this very reason. 3rd revision of the patch: arch/arm/include/asm/smp_scu.h |5 + arch/arm/kernel/smp_scu.c | 16

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 12:56:56PM +, Russell King - ARM Linux wrote: > On Tue, Jan 25, 2011 at 06:06:27PM +0530, Santosh Shilimkar wrote: > > Ok. I missed some information my last email. > > The SCU power status programming is used to take CPU in/out > > of coherency as an alternative to SMP b

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 06:06:27PM +0530, Santosh Shilimkar wrote: > Ok. I missed some information my last email. > The SCU power status programming is used to take CPU in/out > of coherency as an alternative to SMP bit. We don't > have an access to SMP bit on OMAP4. ARM has already > confirmed SCU

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Santosh Shilimkar
fradead.org; > ccr...@android.com > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > I did mean to include the updated patch: As said in other email will work towards this. > > arch/arm/include/asm/smp_scu.h |5 + > arch/arm/kernel/smp_scu.

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Santosh Shilimkar
il.com; linux- > o...@vger.kernel.org > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Tue, Jan 25, 2011 at 05:32:57PM +0530, Santosh Shilimkar wrote: > > I have similar patch implemented but what it does is just > > prepares the value to be progra

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 12:16:56PM +, Russell King - ARM Linux wrote: > On Tue, Jan 25, 2011 at 05:32:57PM +0530, Santosh Shilimkar wrote: > > I have similar patch implemented but what it does is just > > prepares the value to be programmed and stores it to a scratchpad. > > I see your point bu

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Tue, Jan 25, 2011 at 05:32:57PM +0530, Santosh Shilimkar wrote: > I have similar patch implemented but what it does is just > prepares the value to be programmed and stores it to a scratchpad. > I see your point but below patch may now work well. The reason is the SCU > register needs to accesse

RE: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Santosh Shilimkar
il.com; linux- > o...@vger.kernel.org > Subject: Re: [PATCH 4/5] ARM: scu: Move register defines to header > file > > On Mon, Jan 24, 2011 at 02:21:18PM +0530, Santosh Shilimkar wrote: > > This patch moves SCU register defines from smp_scu.c to smp_scu.h > > so that its available f

Re: [PATCH 4/5] ARM: scu: Move register defines to header file

2011-01-25 Thread Russell King - ARM Linux
On Mon, Jan 24, 2011 at 02:21:18PM +0530, Santosh Shilimkar wrote: > This patch moves SCU register defines from smp_scu.c to smp_scu.h > so that its available for platforms to use > > The SCU CPU power status registers is used for power management > on OMAP4. Could we instead have an API inside s