RE: [PATCH resend 2/3] musb: add musb support for AM35x

2010-07-05 Thread Gupta, Ajay Kumar
Hi, > >>> +{ > >>> + unsigned long timeout = jiffies + msecs_to_jiffies(100); > >>> + u32 devconf2; > >>> + > >>> + /* > >>> + * Start the on-chip PHY and its PLL. > >>> + */ > >>> + devconf2 = omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2); > >>> + > >>> + devconf2 &= ~(CONF2_RESET | CONF2_PHYPWRDN |

Re: [PATCH resend 2/3] musb: add musb support for AM35x

2010-07-03 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: +{ + unsigned long timeout = jiffies + msecs_to_jiffies(100); + u32 devconf2; + + /* +* Start the on-chip PHY and its PLL. +*/ + devconf2 = omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2); + + devconf2 &= ~(CONF2_RESET | CON

RE: [PATCH resend 2/3] musb: add musb support for AM35x

2010-07-02 Thread Gupta, Ajay Kumar
> > +#define USB_SOFT_RESET_MASK1 > > Need a empty line here. Hmm, ok. > > > +#define A_WAIT_BCON_TIMEOUT1100/* in ms */ > > I think this #define should be dropped -- see below... > > > +{ > > + unsigned long timeout = jiffies + msecs_to_jiffies(100); > >

Re: [PATCH resend 2/3] musb: add musb support for AM35x

2010-07-02 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode. DMA support can be added later once basic CPPI4.1 DMA patch is accepted. Signed-off-by: Ajay Kumar Gupta [...] diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/mus