RE: [PATCH v5 1/4] ARM: OMAP2+: cleaned-up DT support of various ECC schemes

2013-09-12 Thread Gupta, Pekon
> On Thu, Aug 22, 2013 at 07:56:57AM +, Gupta, Pekon wrote: > If anything, the device entry should somehow describe the various ecc > options > that the hardware implements (if you can't derive that from the compatible > value, which I think you can?). > > > Also I'll try to explain how belo

Re: [PATCH v5 1/4] ARM: OMAP2+: cleaned-up DT support of various ECC schemes

2013-08-27 Thread Olof Johansson
On Thu, Aug 22, 2013 at 07:56:57AM +, Gupta, Pekon wrote: > > This change doesn't look like an improvement to me. > > > [Pekon]: Accepted. I'll drop this. However, this is not a new binding. > I was just elaborating & formatting the description because code allows only > two values "16" or "8"

RE: [PATCH v5 1/4] ARM: OMAP2+: cleaned-up DT support of various ECC schemes

2013-08-22 Thread Gupta, Pekon
> > On Sun, Jul 14, 2013 at 02:24:48AM +0530, Pekon Gupta wrote: > > ECC scheme on NAND devices can be implemented in multiple ways.Some > using > > Software algorithm, while others using in-build Hardware engines. > > omap2-nand driver currently supports following flavours of ECC schemes, > > sel

Re: [PATCH v5 1/4] ARM: OMAP2+: cleaned-up DT support of various ECC schemes

2013-08-21 Thread Olof Johansson
On Sun, Jul 14, 2013 at 02:24:48AM +0530, Pekon Gupta wrote: > ECC scheme on NAND devices can be implemented in multiple ways.Some using > Software algorithm, while others using in-build Hardware engines. > omap2-nand driver currently supports following flavours of ECC schemes, > selectable via DTB