RE: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-15 Thread Mohammed, Afzal
Hi Jon, On Fri, Jun 15, 2012 at 02:36:26, Hunter, Jon wrote: On 06/14/2012 03:48 AM, Mohammed, Afzal wrote: What I meant is we are not dependent on absolute value of flag to find waitpin, and I disagree in depending on its absolute value, which can change, while flag would be the same.

RE: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-14 Thread Mohammed, Afzal
Hi Jon, On Wed, Jun 13, 2012 at 21:14:30, Hunter, Jon wrote: On 06/13/2012 02:37 AM, Mohammed, Afzal wrote: In that case we would be directly depending on user flag whose value may or may not change and I don't think it is good to directly depend on it for waitpin # calculation. You

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-14 Thread Jon Hunter
Hi Afzal, On 06/14/2012 03:48 AM, Mohammed, Afzal wrote: Hi Jon, On Wed, Jun 13, 2012 at 21:14:30, Hunter, Jon wrote: On 06/13/2012 02:37 AM, Mohammed, Afzal wrote: In that case we would be directly depending on user flag whose value may or may not change and I don't think it is good to

RE: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-13 Thread Mohammed, Afzal
Hi Jon, On Tue, Jun 12, 2012 at 23:45:36, Hunter, Jon wrote: GPMC_WAITPIN_IDX0 = 0 GPMC_WAITPIN_0 = 1 So, GPMC_WAITPIN_IDX0 = GPMC_WAITPIN_0 - 1, assuming that you want idx = 0 and not 1. Or you could change you shift value too. I was just highlighting that they are not equal but one set

RE: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-13 Thread Mohammed, Afzal
Hi Jon, On Wed, Jun 13, 2012 at 00:07:46, Hunter, Jon wrote: + case GPMC_WAITPIN_3: + idx = GPMC_WAITPIN_IDX3; + break; + /* no waitpin */ + case 0: + return 0; + break; Do you need the break and return? Not necessary, but to keep

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-13 Thread Jon Hunter
Hi Afzal, On 06/13/2012 02:37 AM, Mohammed, Afzal wrote: Hi Jon, On Tue, Jun 12, 2012 at 23:45:36, Hunter, Jon wrote: GPMC_WAITPIN_IDX0 = 0 GPMC_WAITPIN_0 = 1 So, GPMC_WAITPIN_IDX0 = GPMC_WAITPIN_0 - 1, assuming that you want idx = 0 and not 1. Or you could change you shift value too.

RE: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-12 Thread Mohammed, Afzal
Hi Jon, On Tue, Jun 12, 2012 at 04:29:09, Hunter, Jon wrote: +enum { + GPMC_WAITPIN_IDX0, + GPMC_WAITPIN_IDX1, + GPMC_WAITPIN_IDX2, + GPMC_WAITPIN_IDX3, + GPMC_NR_WAITPIN +}; Max number of wait pins is 3 for omap4/5. I know that we discussed this in the past, but are

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-12 Thread Jon Hunter
On 06/12/2012 04:00 AM, Mohammed, Afzal wrote: Hi Jon, On Tue, Jun 12, 2012 at 04:29:09, Hunter, Jon wrote: +enum { + GPMC_WAITPIN_IDX0, + GPMC_WAITPIN_IDX1, + GPMC_WAITPIN_IDX2, + GPMC_WAITPIN_IDX3, + GPMC_NR_WAITPIN +}; Max number of wait pins is 3 for omap4/5. I know

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-12 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: Helper for configuring waitpin. There are two parts to it; configuring at CS level and the other at device level. A device embedding multiple CS has been provided the capability to use same waitpin (different waitpins has not been supported as

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: Helper for configuring waitpin. There are two parts to it; configuring at CS level and the other at device level. A device embedding multiple CS has been provided the capability to use same waitpin (different waitpins has not been supported as