RE: [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-10-12 Thread Gupta, Pekon
Hi Brian, Thanks for such detailed review, please see some replies below.. From: Brian Norris [mailto:computersforpe...@gmail.com] On Fri, Oct 11, 2013 at 07:06:40PM +0530, Pekon Gupta wrote: [...] Why do you even need the #ifdef's for the #include's? It is not harmful to include headers

Re: [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-10-12 Thread Brian Norris
Hi Pekon, On 10/12/2013 04:58 PM, Gupta, Pekon wrote: From: Brian Norris [mailto:computersforpe...@gmail.com] On Fri, Oct 11, 2013 at 07:06:40PM +0530, Pekon Gupta wrote: [...] Why do you even need the #ifdef's for the #include's? It is not harmful to include headers for stuff that is only

Re: [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-10-11 Thread Felipe Balbi
On Fri, Oct 11, 2013 at 07:06:40PM +0530, Pekon Gupta wrote: OMAP NAND driver support multiple ECC scheme, which can used in following different flavours, depending on in-build Hardware engines supported by SoC. +---+---+---+ | ECC

Re: [PATCH v8 3/6] mtd:nand:omap2: clean-up BCHx_HW and BCHx_SW ECC configurations in device_probe

2013-10-11 Thread Brian Norris
On Fri, Oct 11, 2013 at 07:06:40PM +0530, Pekon Gupta wrote: OMAP NAND driver support multiple ECC scheme, which can used in following different flavours, depending on in-build Hardware engines supported by SoC. +---+---+---+ | ECC