Re: [PATCHv3 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-05-04 Thread Dmitry Torokhov
On Fri, Apr 30, 2010 at 07:49:20PM +0530, Govindarajan, Sriramakrishnan wrote: [Sriram] Dmitry, once you have reviewed the changes, should I re-post the patch series with your patch added to the series? Sriram, Thank you for reviewing my changes. I folded my changes into your original

RE: [PATCHv3 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-04-30 Thread Govindarajan, Sriramakrishnan
-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Friday, April 16, 2010 10:55 AM To: Govindarajan, Sriramakrishnan Cc: linux-omap@vger.kernel.org; linux-in...@vger.kernel.org Subject: Re: [PATCHv3 1/3] TCA6416 keypad : Implement keypad driver

Re: [PATCHv3 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-04-15 Thread Dmitry Torokhov
On Tue, Mar 23, 2010 at 08:40:33PM +0530, Sriramakrishnan wrote: This patch implements a simple Keypad driver that functions as an I2C client. It handles key press events for keys connected to TCA6416 I2C based IO expander. Signed-off-by: Sriramakrishnan s...@ti.com ---

Re: [PATCHv3 1/3] TCA6416 keypad : Implement keypad driver for keys interfaced to TCA6416

2010-04-04 Thread Abraham Arce
Sriramakrishnan, Find minor changes proposals... + +         Say Y here if your device has keys connected to +         TCA6416 IO expander. Your board-specific setup logic +         must also provide pin-mask details(of which TCA6416 pins +         are used for keypad). space in details (