Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-20 Thread Grant Likely
On Wed, Jul 20, 2011 at 4:33 PM, Shawn Guo wrote: > On Wed, Jul 20, 2011 at 12:55:13PM -0600, Grant Likely wrote: >> On Wed, Jul 20, 2011 at 07:04:20PM +0800, Shawn Guo wrote: >> > > Mostly consistency.  Most of the experience we have with the flattened >> > > device tree up to this point hasn't b

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-20 Thread Shawn Guo
On Wed, Jul 20, 2011 at 12:55:13PM -0600, Grant Likely wrote: > On Wed, Jul 20, 2011 at 07:04:20PM +0800, Shawn Guo wrote: > > > Mostly consistency. Most of the experience we have with the flattened > > > device tree up to this point hasn't bothered with the 'status' > > > property. It is only wh

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-20 Thread Grant Likely
On Wed, Jul 20, 2011 at 07:04:20PM +0800, Shawn Guo wrote: > > Mostly consistency. Most of the experience we have with the flattened > > device tree up to this point hasn't bothered with the 'status' > > property. It is only when AMP and hypervisors cam online that it > > became important to use

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-20 Thread Shawn Guo
On Wed, Jul 06, 2011 at 06:12:49PM -0600, Grant Likely wrote: > On Wed, Jul 6, 2011 at 5:26 PM, Stephen Warren wrote: > > Grant Likely wrote at Wednesday, July 06, 2011 12:56 PM: > >> On Thu, Jun 30, 2011 at 03:07:23PM +0500, G, Manjunath Kondaiah wrote: > >> > Add I2C and it's child device nodes

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-06 Thread Grant Likely
On Wed, Jul 6, 2011 at 5:26 PM, Stephen Warren wrote: > Grant Likely wrote at Wednesday, July 06, 2011 12:56 PM: >> On Thu, Jun 30, 2011 at 03:07:23PM +0500, G, Manjunath Kondaiah wrote: >> > Add I2C and it's child device nodes for beagle board. >> > The I2C1 controller child devices are not popul

RE: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-06 Thread Stephen Warren
Grant Likely wrote at Wednesday, July 06, 2011 12:56 PM: > On Thu, Jun 30, 2011 at 03:07:23PM +0500, G, Manjunath Kondaiah wrote: > > Add I2C and it's child device nodes for beagle board. > > The I2C1 controller child devices are not populated and it > > should be handled along with OMAP clock chan

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-06 Thread Grant Likely
On Thu, Jun 30, 2011 at 03:07:23PM +0500, G, Manjunath Kondaiah wrote: > > Add I2C and it's child device nodes for beagle board. > The I2C1 controller child devices are not populated and it > should be handled along with OMAP clock changes. > > Signed-off-by: G, Manjunath Kondaiah > --- > arch/

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-07-06 Thread Grant Likely
On Thu, Jun 30, 2011 at 07:27:02AM -0700, Tony Lindgren wrote: > Hi, > > Few comments on the .dts data layout below. > > * G, Manjunath Kondaiah [110630 02:44]: > > --- a/arch/arm/boot/dts/omap3-beagle-nunchuck.dts > > +++ b/arch/arm/boot/dts/omap3-beagle-nunchuck.dts > > @@ -2,11 +2,6 @@ > >

Re: [RFC PATCH 1/5] OMAP3:I2C: Add device tree nodes for beagle board

2011-06-30 Thread Tony Lindgren
Hi, Few comments on the .dts data layout below. * G, Manjunath Kondaiah [110630 02:44]: > --- a/arch/arm/boot/dts/omap3-beagle-nunchuck.dts > +++ b/arch/arm/boot/dts/omap3-beagle-nunchuck.dts > @@ -2,11 +2,6 @@ > > / { > i2c@48072000 { > - compatible = "ti,omap3-i2c"; > -