RE: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Shilimkar, Santosh
; Krishnamoorthy, Balaji T Subject: Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec On Tue, Oct 06, 2009 at 11:46:05AM +0300, Peter Ujfalusi wrote: How does the twl4030 series would fit with this modification? I have also added the twl4030 codec as a child

Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Peter Ujfalusi
On Tuesday 06 October 2009 19:53:03 ext Lopez Cruz, Misael wrote: Peter Ujfalusi wrote: How does the twl4030 series would fit with this modification? I have also added the twl4030 codec as a child for the twl MFD, but I have not finished the cleanup of the codec fully. twl6030 codec data

Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Peter Ujfalusi
On Wednesday 07 October 2009 08:20:35 ext Krishnamoorthy, Balaji T wrote: #define twl_has_mmc() false #endif +#if defined(CONFIG_SND_SOC_TWL6030) || defined(CONFIG_SND_SOC_TWL6030_MODULE) || defined(CONFIG_SND_SOC_TWL4030) || defined(CONFIG_SND_SOC_TWL4030_MODULE)

Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Mark Brown
On Wed, Oct 07, 2009 at 11:56:38AM +0530, Shilimkar, Santosh wrote: [I've reflowed your mail to fit into 80 columns] Since there is some sort of dependency on ASOC series with TWL_6030 core series by Balaji, its better that these gets merged in correct order to avoid reworks. There's no

RE: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Shilimkar, Santosh
, Balaji T Subject: Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec On Wed, Oct 07, 2009 at 11:56:38AM +0530, Shilimkar, Santosh wrote: [I've reflowed your mail to fit into 80 columns] Since there is some sort of dependency on ASOC series with TWL_6030 core series

RE: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-07 Thread Lopez Cruz, Misael
Krishnamoorthy, Balaji T wrote: CONFIG_TWL6030_CORE and CONFIG_TWL4030_CORE is merged to CONFIG_TWL_CORE As two different build config was not encouraged. Now switch twl_class_is_6030() will be used to decide at runtime time to support for 6030 related drivers, Similarly twl_class_is_4030()

Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-06 Thread Peter Ujfalusi
On Tuesday 06 October 2009 10:29:39 ext Lopez Cruz, Misael wrote: In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data structure. For twl6030 audio codec, the following data may be passed: - audpwron_gpio: gpio line used to

Re: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-06 Thread Mark Brown
On Tue, Oct 06, 2009 at 11:46:05AM +0300, Peter Ujfalusi wrote: How does the twl4030 series would fit with this modification? I have also added the twl4030 codec as a child for the twl MFD, but I have not finished the cleanup of the codec fully. The TWL6030 specific bits all look good but

RE: [alsa-devel] [PATCHv3 1/7] OMAP4: PMIC: Add support for twl6030 codec

2009-10-06 Thread Lopez Cruz, Misael
Peter Ujfalusi wrote: On Tuesday 06 October 2009 10:29:39 ext Lopez Cruz, Misael wrote: In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data structure. For twl6030 audio codec, the following data may be passed: - audpwron_gpio: